[NETBEANS-3670] - cleanup addElement() unchecked calls

Cleanup a bunch of warnings related to uncheck call to addEelement()

[repeat] /home/bwalker/src/netbeans/platform/api.progress/src/org/netbeans/modules/progress/spi/TaskModel.java:67: warning: [unchecked] unchecked call to addElement(E) as a member of the raw type DefaultListModel
[repeat] model.addElement(handle);
[repeat] ^
[repeat] where E is a type-variable:
[repeat] E extends Object declared in class DefaultListModel
[repeat] 1 warning

apisupport/apisupport.wizards/nbproject/project.properties

@@ -14,6 +14,6 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-javac.source=1.6
+javac.source=1.8
 javac.compilerargs=-Xlint -Xlint:-serial
 requires.nb.javac=true

apisupport/apisupport.wizards/src/org/netbeans/modules/apisupport/project/ui/wizard/action/GUIRegistrationPanel.java

@@ -342,7 +342,7 @@ public void run() {
     private void createPositionModel(final JComboBox positionsCombo,
             final FileObject[] files,
             final LayerItemPresenter parent) {
-        DefaultComboBoxModel newModel = new DefaultComboBoxModel();
+        DefaultComboBoxModel<Position> newModel = new DefaultComboBoxModel<>();
         LayerItemPresenter previous = null;
         for (FileObject file : files) {
             if (file.getNameExt().endsWith(LayerUtil.HIDDEN)) {

enterprise/glassfish.eecommon/src/org/netbeans/modules/glassfish/eecommon/api/VerifierSupport.java

@@ -79,6 +79,7 @@
 import org.openide.windows.Mode;
 import org.openide.windows.TopComponent;
 import org.openide.windows.WindowManager;
+import org.netbeans.modules.j2ee.sun.dd.impl.verifier.Error;
 
 /**
  * Main TopComponent to display the output of the Sun J2EE Verifier Tool from an archive file.
@@ -128,10 +129,10 @@ public class VerifierSupport extends TopComponent {
         NbBundle.getMessage(VerifierSupport.class,STATUS_LIT),
         NbBundle.getMessage(VerifierSupport.class,"Test_Description"),      // NOI18N
         NbBundle.getMessage(VerifierSupport.class,"Result")};       // NOI18N
-    private Vector passResults = new Vector();
-    private Vector failResults = new Vector();
-    private Vector errorResults = new Vector();
-    private Vector warnResults = new Vector();
+    private Vector<Test> passResults = new Vector<>();
+    private Vector<Test> failResults = new Vector<>();
+    private Vector<Error> errorResults = new Vector<>();
+    private Vector<Test>  warnResults  = new Vector<>();
     private Vector naResults = new Vector();
     private Vector notImplementedResults = new Vector();
     private Vector notRunResults = new Vector();
@@ -882,7 +883,7 @@ public void saveFailResultsForDisplay(Test r){
      *
      * @param r
      */
-    public void saveErrorResultsForDisplay(org.netbeans.modules.j2ee.sun.dd.impl.verifier.Error r){
+    public void saveErrorResultsForDisplay(Error r){
         errorResults.addElement(r);
     }
 

enterprise/javaee.project/src/org/netbeans/modules/javaee/project/api/ant/ui/wizard/ProjectServerPanel.java

@@ -65,7 +65,7 @@ final class ProjectServerPanel extends javax.swing.JPanel implements DocumentLis
 
     private ProjectServerWizardPanel wizard;
     private boolean contextModified = false;
-    private final DefaultComboBoxModel serversModel = new DefaultComboBoxModel();
+    private final DefaultComboBoxModel<ServerInstanceWrapper> serversModel = new DefaultComboBoxModel<>();
 
     private J2eeVersionWarningPanel warningPanel;
     private boolean sharableProject;

enterprise/payara.eecommon/src/org/netbeans/modules/payara/eecommon/api/VerifierSupport.java

@@ -79,6 +79,7 @@
 import org.openide.windows.Mode;
 import org.openide.windows.TopComponent;
 import org.openide.windows.WindowManager;
+import org.netbeans.modules.j2ee.sun.dd.impl.verifier.Error;
 
 /**
  * Main TopComponent to display the output of the Sun J2EE Verifier Tool from an archive file.
@@ -128,10 +129,10 @@ public class VerifierSupport extends TopComponent {
         NbBundle.getMessage(VerifierSupport.class,STATUS_LIT),
         NbBundle.getMessage(VerifierSupport.class,"Test_Description"),      // NOI18N
         NbBundle.getMessage(VerifierSupport.class,"Result")};       // NOI18N
-    private Vector passResults = new Vector();
-    private Vector failResults = new Vector();
-    private Vector errorResults = new Vector();
-    private Vector warnResults = new Vector();
+    private Vector<Test> passResults = new Vector<>();
+    private Vector<Test> failResults = new Vector<>();
+    private Vector<Test> warnResults = new Vector<>();
+    private Vector<Error> errorResults = new Vector<>();
     private Vector naResults = new Vector();
     private Vector notImplementedResults = new Vector();
     private Vector notRunResults = new Vector();
@@ -882,7 +883,7 @@ public void saveFailResultsForDisplay(Test r){
      *
      * @param r
      */
-    public void saveErrorResultsForDisplay(org.netbeans.modules.j2ee.sun.dd.impl.verifier.Error r){
+    public void saveErrorResultsForDisplay(Error r){
         errorResults.addElement(r);
     }
 

enterprise/web.freeform/src/org/netbeans/modules/web/freeform/ui/WebClasspathPanel.java

@@ -46,7 +46,7 @@
  */
 public class WebClasspathPanel extends javax.swing.JPanel implements HelpCtx.Provider {
 
-    private DefaultListModel listModel;
+    private DefaultListModel<String> listModel;
     /** Original project folder (not nbproject folder) */
     private File projectFolder = null;
     /** Freeform Project base folder */
@@ -263,9 +263,9 @@ private void moveDownActionPerformed(java.awt.event.ActionEvent evt) {//GEN-FIRS
         }
         for (int i = 0; i < indices.length; i++) {
             int index = indices[i];
-            Object o = listModel.remove(index);
+            String s = listModel.remove(index);
             index++;
-            listModel.add(index, o);
+            listModel.add(index, s);
             indices[i] = index;
         }
         classpath.setSelectedIndices(indices);
@@ -279,9 +279,9 @@ private void moveUpActionPerformed(java.awt.event.ActionEvent evt) {//GEN-FIRST:
         }
         for (int i = 0; i < indices.length; i++) {
             int index = indices[i];
-            Object o = listModel.remove(index);
+            String s = listModel.remove(index);
             index--;
-            listModel.add(index, o);
+            listModel.add(index, s);
             indices[i] = index;
         }
         classpath.setSelectedIndices(indices);

enterprise/web.project/src/org/netbeans/modules/web/project/ui/customizer/AddFrameworkPanel.java

@@ -46,7 +46,7 @@ public AddFrameworkPanel(List usedFrameworks) {
 
     private void createFrameworksList(List usedFrameworks) {
         List frameworks = WebFrameworks.getFrameworks();
-	DefaultListModel model = new DefaultListModel();
+	DefaultListModel<WebFrameworkProvider> model = new DefaultListModel<>();
 	jListFrameworks.setModel(model);
 
 	for (int i = 0; i < frameworks.size(); i++) {

enterprise/web.project/src/org/netbeans/modules/web/project/ui/wizards/PanelSupportedFrameworksVisual.java

@@ -462,10 +462,10 @@ public void setBooleanRenderer(TableCellRenderer booleanRenderer) {
      * Implements a TableModel.
      */
     public static final class FrameworksTableModel extends AbstractTableModel {
-        private DefaultListModel model;
+        private DefaultListModel<FrameworkModelItem> model;
 
         public FrameworksTableModel() {
-            model = new DefaultListModel();
+            model = new DefaultListModel<>();
         }
 
         public int getColumnCount() {

enterprise/web.struts/src/org/netbeans/modules/web/struts/dialogs/AddActionPanel.java

@@ -46,7 +46,7 @@ public AddActionPanel(StrutsConfigDataObject dObject) {
         config=dObject;
         initComponents();
         List actions = StrutsConfigUtilities.getAllActionsInModule(dObject);
-        DefaultComboBoxModel model = (DefaultComboBoxModel)CBInputAction.getModel();
+        DefaultComboBoxModel<String> model = (DefaultComboBoxModel)CBInputAction.getModel();
         Iterator iter = actions.iterator();
         while (iter.hasNext())
             model.addElement(((Action)iter.next()).getAttributeValue("path")); //NOI18N

enterprise/web.struts/src/org/netbeans/modules/web/struts/dialogs/AddForwardDialogPanel.java

@@ -41,8 +41,8 @@ public AddForwardDialogPanel(StrutsConfigDataObject config, String targetActionP
         this.config=config;
         initComponents();
         List actions = StrutsConfigUtilities.getAllActionsInModule(config);
-        DefaultComboBoxModel model = (DefaultComboBoxModel)jComboBoxFwdAction.getModel();
-        DefaultComboBoxModel model1 = (DefaultComboBoxModel)jComboBoxLocationAction.getModel();
+        DefaultComboBoxModel<String> model  = (DefaultComboBoxModel<String>)jComboBoxFwdAction.getModel();
+        DefaultComboBoxModel<String> model1 = (DefaultComboBoxModel<String>)jComboBoxLocationAction.getModel();
         Iterator iter = actions.iterator();
         while (iter.hasNext()) {
             String actionPath=((Action)iter.next()).getAttributeValue("path"); //NOI18N

ide/api.debugger/src/org/netbeans/api/debugger/DebuggerManager.java

@@ -163,7 +163,7 @@ public final class DebuggerManager implements ContextProvider {
     private final Vector                      breakpoints = new Vector ();
     private boolean                           breakpointsInitializing = false;
     private boolean                           breakpointsInitialized = false;
-    private final Vector                      watches = new Vector ();
+    private final Vector<Watch>               watches = new Vector<>();
     private boolean                           watchesInitialized = false;
     private ThreadLocal<Boolean>              watchesInitializing = new ThreadLocal<Boolean>();
     private SessionListener                   sessionListener = new SessionListener ();
@@ -706,7 +706,7 @@ public void reorderWatches(final int[] permutation) throws IllegalArgumentExcept
                 throw new IllegalArgumentException("Permutation of length "+permutation.length+", but have "+watches.size()+" watches.");
             }
             checkPermutation(permutation);
-            Vector v = (Vector) watches.clone ();
+            Vector<Watch> v = (Vector<Watch>)watches.clone();
             for (int i = 0; i < v.size(); i++) {
                 watches.set(permutation[i], v.get(i));
             }

ide/css.editor/src/org/netbeans/modules/css/editor/ui/CssRuleCreateActionDialog.java

@@ -63,7 +63,7 @@ public CssRuleCreateActionDialog() {
         String[] htmlTags = HtmlTags.getTags();
 
         // Optional prefix
-        DefaultComboBoxModel htmlTagsModel1 = new DefaultComboBoxModel();
+        DefaultComboBoxModel<String> htmlTagsModel1 = new DefaultComboBoxModel<>();
         htmlTagsModel1.addElement(NONE);
         htmlTagsModel1.addElement("a:link");
         htmlTagsModel1.addElement("a:visited");

ide/languages/nbproject/project.properties

@@ -17,7 +17,7 @@
 build.compiler.deprecation=false
 is.autoload=true
 javac.compilerargs=-Xlint:unchecked
-javac.source=1.6
+javac.source=1.8
 javadoc.arch=${basedir}/arch.xml
 spec.version.base=1.128.0
 

ide/languages/src/org/netbeans/modules/languages/dataobject/GLFFilesCustomEditor.java

@@ -46,7 +46,7 @@ public GLFFilesCustomEditor () {
         initComponents ();
         List<String> mimeTypes = getSupportedMimeTypes ();
         Collections.sort (mimeTypes);
-        DefaultListModel model = new DefaultListModel ();
+        DefaultListModel<String> model = new DefaultListModel<>();
         Iterator<String> it = mimeTypes.iterator ();
         while (it.hasNext ()) {
             String name = (String) it.next ();

ide/mercurial/src/org/netbeans/modules/mercurial/ui/log/SearchHistoryPanel.java

@@ -794,7 +794,7 @@ Collection<SearchHighlight> getSearchHighlights () {
     }
 
     private void initializeFilter () {
-        DefaultComboBoxModel filterModel = new DefaultComboBoxModel();
+        DefaultComboBoxModel<FilterKind> filterModel = new DefaultComboBoxModel<>();
         filterModel.addElement(FilterKind.ALL);
         filterModel.addElement(FilterKind.ID);
         filterModel.addElement(FilterKind.MESSAGE);

ide/mercurial/src/org/netbeans/modules/mercurial/ui/repository/ChangesetPickerPanel.java

@@ -445,7 +445,7 @@ private class InitialLoadingProgressSupport extends HgProgressSupport {
         @Override
         public void perform () {
             try {
-                final DefaultListModel targetsModel = new DefaultListModel();
+                final DefaultListModel<HgLogMessage> targetsModel = new DefaultListModel<>();
                 final HgLogMessage displayedRevision = getDisplayedRevision();
                 if (displayedRevision == null) {
                     if (acceptSelection(NO_REVISION)) {

ide/options.editor/src/org/netbeans/modules/options/editor/FolderBasedOptionPanel.java

@@ -76,7 +76,7 @@ public Component getListCellRendererComponent(JList list, Object value, int inde
     }
 
     void update () {
-        DefaultComboBoxModel model = new DefaultComboBoxModel();
+        DefaultComboBoxModel<String> model = new DefaultComboBoxModel<>();
         for (String mimeType : controller.getMimeTypes()) {
             model.addElement(mimeType);
         }

ide/options.editor/src/org/netbeans/modules/options/indentation/FormattingPanel.java

@@ -108,7 +108,7 @@ public void setSelector(CustomizerSelector selector) {
 
         if (this.selector != null) {
             // Languages combobox model
-            DefaultComboBoxModel model = new DefaultComboBoxModel();
+            DefaultComboBoxModel<String> model = new DefaultComboBoxModel<>();
             ArrayList<String> mimeTypes = new ArrayList<String>();
             mimeTypes.addAll(selector.getMimeTypes());
             Collections.sort(mimeTypes, new LanguagesComparator());
@@ -142,7 +142,7 @@ public void setSelector(CustomizerSelector selector) {
 
     public void propertyChange(PropertyChangeEvent evt) {
         if (evt.getPropertyName() == null || CustomizerSelector.PROP_MIMETYPE.equals(evt.getPropertyName())) {
-            DefaultComboBoxModel model = new DefaultComboBoxModel();
+            DefaultComboBoxModel<PreferencesCustomizer> model = new DefaultComboBoxModel();
             List<? extends PreferencesCustomizer> nue = selector.getCustomizers(selector.getSelectedMimeType());
             int preSelectIndex = 0;
             int idx = 0;

ide/project.ant.ui/src/org/netbeans/spi/project/support/ant/ui/LicenseHeadersPanel.java

@@ -328,7 +328,7 @@ private void btnProjectActionPerformed(java.awt.event.ActionEvent evt) {//GEN-FI
 
     private void loadGlobalLicenses() {
         FileObject root = FileUtil.getConfigFile("Templates/Licenses");
-        DefaultComboBoxModel model = new DefaultComboBoxModel();
+        DefaultComboBoxModel<GlobalItem> model = new DefaultComboBoxModel<>();
         for (FileObject fo : root.getChildren()) {
             if (fo.getAttribute("template") == null) {
                 continue;

ide/projectui/src/org/netbeans/modules/project/ui/ExitDialog.java

@@ -67,15 +67,15 @@ final public class ExitDialog extends JPanel implements ActionListener {
     private static boolean result = false;
 
     JList list;
-    DefaultListModel listModel;
+    DefaultListModel<DataObject> listModel;
 
     /** Constructs new dlg for unsaved files in filesystems marked 
      * for unmount.
     */
     private ExitDialog (Set<DataObject> openedFiles) {
         setLayout (new BorderLayout ());
 
-        listModel = new DefaultListModel();
+        listModel = new DefaultListModel<>();
 
         Set<DataObject> set = getModifiedFiles (openedFiles);
         if (!set.isEmpty ()) {

ide/spellchecker/nbproject/project.properties

@@ -17,7 +17,7 @@
 # under the License.
 #
 javac.compilerargs=-Xlint:unchecked
-javac.source=1.6
+javac.source=1.8
 nbm.homepage=http://spellchecker.netbeans.org
 nbm.module.author=Jan Lahoda
 spec.version.base=1.42.0

ide/spellchecker/src/org/netbeans/modules/spellchecker/options/SpellcheckerOptionsPanel.java

@@ -516,7 +516,7 @@ private void defaultLocaleItemStateChanged(java.awt.event.ItemEvent evt) {//GEN-
     // End of variables declaration//GEN-END:variables
 
     private ListModel getInstalledDictionariesModel() {
-        DefaultListModel dlm = new DefaultListModel();
+        DefaultListModel<Locale> dlm = new DefaultListModel<>();
 
         for (Locale l : DictionaryProviderImpl.getInstalledDictionariesLocales()) {
             dlm.addElement(l);

ide/subversion/src/org/netbeans/modules/subversion/ui/copy/BranchPicker.java

@@ -109,7 +109,7 @@ String getSelectedPath () {
     }
 
     private void initializeItems () {
-        DefaultListModel model = new DefaultListModel();
+        DefaultListModel<String> model = new DefaultListModel<>();
         model.addElement(ITEM_BRANCHES);
         model.addElement(ITEM_LOADING);
         model.addElement(ITEM_SEP);
@@ -141,7 +141,7 @@ protected void perform () {
 
                             @Override
                             public void run () {
-                                DefaultListModel model = new DefaultListModel();
+                                DefaultListModel<String> model = new DefaultListModel<>();
                                 model.addElement(ITEM_BRANCHES);
                                 for (ISVNDirEntry e : entries.get(PREFIX_BRANCHES)) {
                                     model.addElement(branchesFolderPrefix + PREFIX_BRANCHES + "/" + e.getPath()); //NOI18N

ide/tasklist.ui/nbproject/project.properties

@@ -15,7 +15,7 @@
 # specific language governing permissions and limitations
 # under the License.
 javac.compilerargs=-Xlint:unchecked
-javac.source=1.6
+javac.source=1.8
 spec.version.base=1.38.0
 
 test.config.stableBTD.includes=**/*Test.class

ide/team.commons/src/org/netbeans/modules/bugtracking/commons/AttachmentPanel.java

@@ -51,7 +51,7 @@ public AttachmentPanel(AttachmentsPanel.NBBugzillaCallback nbCallback) {
     }
 
     private void initFileTypeCombo() {
-        DefaultComboBoxModel model = new DefaultComboBoxModel();
+        DefaultComboBoxModel<FileType> model = new DefaultComboBoxModel<>();
         ResourceBundle bundle = NbBundle .getBundle(AttachmentPanel.class);
         model.addElement(new FileType(null, bundle.getString("AttachmentPanel.fileType.automatic"))); // NOI18N
         model.addElement(new FileType("text/plain", bundle.getString("AttachmentPanel.fileType.textPlain"))); // NOI18N

ide/team.commons/src/org/netbeans/modules/bugtracking/commons/ListValuePicker.java

@@ -69,7 +69,7 @@ private ListValuePicker(String label, String message, ListValue[] knownValues, S
         org.openide.awt.Mnemonics.setLocalizedText(valuesLabel, label); 
 
         valuesList.setCellRenderer(new ListValueRenderer());
-        DefaultListModel model = new DefaultListModel();
+        DefaultListModel<ListValue> model = new DefaultListModel<>();
         for (ListValue lvalue : knownValues) {
             model.addElement(lvalue);
         }

ide/versioning.ui/nbproject/project.properties

@@ -17,6 +17,6 @@
 
 is.eager=true
 javac.compilerargs=-Xlint:unchecked
-javac.source=1.6
+javac.source=1.8
 
 spec.version.base=1.29.0

ide/versioning.ui/src/org/netbeans/modules/versioning/ui/options/GeneralOptionsPanel.java

@@ -91,7 +91,7 @@ Collection<String> getKeywords () {
     private void fillDisconnectedFolders () {
         if (cmbVersioningSystems.getSelectedItem() instanceof VersioningSystem) {
             String[] disconnected = Utils.getDisconnectedRoots(((VersioningSystem) cmbVersioningSystems.getSelectedItem()));
-            DefaultListModel model = new DefaultListModel();
+            DefaultListModel<String> model = new DefaultListModel<>();
             for (String f : disconnected) {
                 model.addElement(f);
             }

ide/web.browser.api/src/org/netbeans/modules/web/browser/ui/DeveloperToolbar.java

@@ -144,7 +144,7 @@ public void intialize( Lookup context ) {
         panel.add( bar );
 
         //ZOOM combo box
-        DefaultComboBoxModel zoomModel = new DefaultComboBoxModel();
+        DefaultComboBoxModel<String> zoomModel = new DefaultComboBoxModel<>();
         zoomModel.addElement( "200%" ); //NOI18N
         zoomModel.addElement( "150%" ); //NOI18N
         zoomModel.addElement( "100%" ); //NOI18N

java/j2ee.jpa.verification/src/org/netbeans/modules/j2ee/jpa/verification/fixes/CreateRelationshipPanel.java

@@ -41,7 +41,7 @@ class CreateRelationshipPanel extends javax.swing.JPanel {
     public enum NameStatus {VALID, ILLEGAL_JAVA_ID, ILLEGAL_SQL_KEYWORD,  DUPLICATE};
     public enum AvailableSelection {INVERSE_ONLY, OWNING_ONLY, BOTH};
     private Collection<String> availableFields;
-    private DefaultComboBoxModel mdlAvailableFields = new DefaultComboBoxModel();
+    private DefaultComboBoxModel<String> mdlAvailableFields = new DefaultComboBoxModel<>();
     private FieldNameValidator nameValidator = null;
     private Border brdrBlack = BorderFactory.createLineBorder(Color.BLACK);
     private DialogDescriptor dlgDescriptor = null;