Don't call getPreEmitDiagnostics in tests (palantir#2769)

docs/develop/testing-rules/index.md

@@ -160,6 +160,8 @@ The following part can be any [version range](https://github.com/npm/node-semver
 * You can use this system to test rules outside of the TSLint build! Use the `tslint --test path/to/dir` command to test your own custom rules.
 The directory you pass should contain a `tslint.json` file and `.ts.lint` files. You can try this out on the TSLint rule test cases, for example, `tslint --test path/to/tslint-code/test/rules/quotemark/single`.
 
+* To test rules that need type information, you can simply add a `tsconfig.json` with the desired configuration next to `tslint.json`.
+
 * Lint failures sometimes span over multiple lines. To handle this case, don't specify a message until the end of the error. For example:
 
 ```

src/test.ts

@@ -70,7 +70,8 @@ export function runTest(testDirectory: string, rulesDirectory?: string | string[
     const tslintConfig = Linter.findConfiguration(path.join(testDirectory, "tslint.json"), "").results;
     const tsConfig = path.join(testDirectory, "tsconfig.json");
     let compilerOptions: ts.CompilerOptions = { allowJs: true };
-    if (fs.existsSync(tsConfig)) {
+    const hasConfig = fs.existsSync(tsConfig);
+    if (hasConfig) {
         const {config, error} = ts.readConfigFile(tsConfig, ts.sys.readFile);
         if (error !== undefined) {
             throw new Error(JSON.stringify(error));
@@ -111,7 +112,7 @@ export function runTest(testDirectory: string, rulesDirectory?: string | string[
         const errorsFromMarkup = parse.parseErrorsFromMarkup(fileText);
 
         let program: ts.Program | undefined;
-        if (tslintConfig !== undefined && tslintConfig.linterOptions !== undefined && tslintConfig.linterOptions.typeCheck === true) {
+        if (hasConfig) {
             const compilerHost: ts.CompilerHost = {
                 fileExists: () => true,
                 getCanonicalFileName: (filename: string) => filename,
@@ -138,8 +139,6 @@ export function runTest(testDirectory: string, rulesDirectory?: string | string[
             };
 
             program = ts.createProgram([fileCompileName], compilerOptions, compilerHost);
-            // perform type checking on the program, updating nodes with symbol table references
-            ts.getPreEmitDiagnostics(program);
         }
 
         const lintOptions = {

test/rules/await-promise/tslint.json

@@ -1,7 +1,4 @@
 {
-  "linterOptions": {
-    "typeCheck": true
-  },
   "rules": {
     "await-promise": true
   }

test/rules/completed-docs/defaults/tsconfig.json

@@ -0,0 +1,5 @@
+{
+    "compilerOptions": {
+        "module": "commonjs"
+    }
+}

test/rules/completed-docs/defaults/tslint.json

@@ -1,7 +1,4 @@
 {
-  "linterOptions": {
-    "typeCheck": true
-  },
   "rules": {
     "completed-docs": true
   }

test/rules/completed-docs/locations/tsconfig.json

@@ -0,0 +1,5 @@
+{
+    "compilerOptions": {
+        "module": "commonjs"
+    }
+}

test/rules/completed-docs/locations/tslint.json

@@ -1,7 +1,4 @@
 {
-  "linterOptions": {
-    "typeCheck": true
-  },
   "rules": {
     "completed-docs": [true, {
       "methods": {

test/rules/completed-docs/privacies-private/tsconfig.json

@@ -0,0 +1,5 @@
+{
+    "compilerOptions": {
+        "module": "commonjs"
+    }
+}

test/rules/completed-docs/privacies-private/tslint.json

@@ -1,7 +1,4 @@
 {
-  "linterOptions": {
-    "typeCheck": true
-  },
   "rules": {
     "completed-docs": [true, {
       "methods": {

test/rules/completed-docs/privacies-protected/tsconfig.json

@@ -0,0 +1,5 @@
+{
+    "compilerOptions": {
+        "module": "commonjs"
+    }
+}

test/rules/completed-docs/privacies-protected/tslint.json

@@ -1,7 +1,4 @@
 {
-  "linterOptions": {
-    "typeCheck": true
-  },
   "rules": {
     "completed-docs": [true, {
       "methods": {

test/rules/completed-docs/privacies-public/tsconfig.json

@@ -0,0 +1,5 @@
+{
+    "compilerOptions": {
+        "module": "commonjs"
+    }
+}

test/rules/completed-docs/privacies-public/tslint.json

@@ -1,7 +1,4 @@
 {
-  "linterOptions": {
-    "typeCheck": true
-  },
   "rules": {
     "completed-docs": [true, {
       "methods": {

test/rules/completed-docs/privacies/tsconfig.json

@@ -0,0 +1,5 @@
+{
+    "compilerOptions": {
+        "module": "commonjs"
+    }
+}

test/rules/completed-docs/privacies/tslint.json

@@ -1,7 +1,4 @@
 {
-  "linterOptions": {
-    "typeCheck": true
-  },
   "rules": {
     "completed-docs": [true, {
       "methods": {

test/rules/completed-docs/types/tsconfig.json

@@ -0,0 +1,5 @@
+{
+    "compilerOptions": {
+        "module": "commonjs"
+    }
+}

test/rules/completed-docs/types/tslint.json

@@ -1,7 +1,4 @@
 {
-  "linterOptions": {
-    "typeCheck": true
-  },
   "rules": {
     "completed-docs": [
       true,

test/rules/completed-docs/visibilities/tsconfig.json

@@ -0,0 +1,5 @@
+{
+    "compilerOptions": {
+        "module": "commonjs"
+    }
+}

test/rules/completed-docs/visibilities/tslint.json

@@ -1,7 +1,4 @@
 {
-  "linterOptions": {
-    "typeCheck": true
-  },
   "rules": {
     "completed-docs": [true, {
       "enums": {

test/rules/deprecation/tsconfig.json

@@ -0,0 +1,5 @@
+{
+    "compilerOptions": {
+        "module": "commonjs"
+    }
+}

test/rules/deprecation/tslint.json

@@ -1,7 +1,4 @@
 {
-  "linterOptions": {
-    "typeCheck": true
-  },
   "rules": {
     "deprecation": true
   }

test/rules/match-default-export-name/tsconfig.json

@@ -0,0 +1,5 @@
+{
+    "compilerOptions": {
+        "module": "commonjs"
+    }
+}

test/rules/match-default-export-name/tslint.json

@@ -1,7 +1,4 @@
 {
-  "linterOptions": {
-    "typeCheck": true
-  },
   "rules": {
     "match-default-export-name": true
   }

test/rules/no-boolean-literal-compare/tslint.json

@@ -1,7 +1,4 @@
 {
-    "linterOptions": {
-        "typeCheck": true
-    },
     "rules": {
         "no-boolean-literal-compare": true
     }

test/rules/no-floating-promises/jquerypromise/tsconfig.json

@@ -0,0 +1,5 @@
+{
+    "compilerOptions": {
+        "module": "commonjs"
+    }
+}

test/rules/no-floating-promises/jquerypromise/tslint.json

@@ -1,7 +1,4 @@
 {
-  "linterOptions": {
-    "typeCheck": true
-  },
   "rules": {
     "no-floating-promises": [true, "JQueryPromise"]
   }

test/rules/no-floating-promises/promises/tsconfig.json

@@ -0,0 +1,5 @@
+{
+    "compilerOptions": {
+        "module": "commonjs"
+    }
+}

test/rules/no-floating-promises/promises/tslint.json

@@ -1,7 +1,4 @@
 {
-  "linterOptions": {
-    "typeCheck": true
-  },
   "rules": {
     "no-floating-promises": true
   }

test/rules/no-for-in-array/tsconfig.json

@@ -0,0 +1,5 @@
+{
+    "compilerOptions": {
+        "module": "commonjs"
+    }
+}

test/rules/no-for-in-array/tslint.json

@@ -1,8 +1,5 @@
 {
   "rules": {
     "no-for-in-array": true
-  },
-  "linterOptions": {
-    "typeCheck": true
   }
 }

test/rules/no-import-side-effect/default/test.ts.lint

@@ -1,3 +1,4 @@
+
 // valid cases
 import {Injectable, Component, Directive} from '@angular/core';
 import {Inject} from '@angular/core';

test/rules/no-import-side-effect/default/tslint.json

@@ -1,8 +1,5 @@
 {
   "rules": {
     "no-import-side-effect": [true]
-  },
-  "linterOptions": {
-    "typeCheck": false
   }
 }

test/rules/no-import-side-effect/ignore-module/tslint.json

@@ -6,8 +6,5 @@
         "ignore-module": "(allow-side-effect|\\.css)$"
       }
     ]
-  },
-  "linterOptions": {
-    "typeCheck": false
   }
 }

test/rules/no-inferred-empty-object-type/tsconfig.json

@@ -0,0 +1,5 @@
+{
+    "compilerOptions": {
+        "module": "commonjs"
+    }
+}

test/rules/no-inferred-empty-object-type/tslint.json

@@ -1,7 +1,4 @@
 {
-  "linterOptions": {
-    "typeCheck": true
-  },
   "rules": {
     "no-inferred-empty-object-type": true
   }

test/rules/no-unbound-method/tsconfig.json

@@ -0,0 +1,5 @@
+{
+    "compilerOptions": {
+        "module": "commonjs"
+    }
+}

test/rules/no-unbound-method/tslint.json

@@ -1,7 +1,4 @@
 {
-  "linterOptions": {
-    "typeCheck": true
-  },
   "rules": {
     "no-unbound-method": true
   }

test/rules/no-unnecessary-qualifier/tslint.json

@@ -1,7 +1,4 @@
 {
-    "linterOptions": {
-        "typeCheck": true
-    },
     "rules": {
         "no-unnecessary-qualifier": true
     }

test/rules/no-unnecessary-type-assertion/tslint.json

@@ -1,7 +1,4 @@
 {
-  "linterOptions": {
-    "typeCheck": true
-  },
   "rules": {
     "no-unnecessary-type-assertion": true
   }

test/rules/no-unsafe-any/tsconfig.json

@@ -0,0 +1,5 @@
+{
+    "compilerOptions": {
+        "module": "commonjs"
+    }
+}

test/rules/no-unsafe-any/tslint.json

@@ -1,7 +1,4 @@
 {
-  "linterOptions": {
-    "typeCheck": true
-  },
   "rules": {
     "no-unsafe-any": true
   }

test/rules/no-unused-variable/check-parameters/tsconfig.json

@@ -0,0 +1,5 @@
+{
+    "compilerOptions": {
+        "module": "commonjs"
+    }
+}

test/rules/no-unused-variable/check-parameters/tslint.json

@@ -1,7 +1,4 @@
 {
-  "linterOptions": {
-    "typeCheck": true
-  },
   "rules": {
      "no-unused-variable": [true, "check-parameters"]
   }

test/rules/no-unused-variable/default/tsconfig.json

@@ -0,0 +1,5 @@
+{
+    "compilerOptions": {
+        "module": "commonjs"
+    }
+}

test/rules/no-unused-variable/default/tslint.json

@@ -1,7 +1,4 @@
 {
-  "linterOptions": {
-    "typeCheck": true
-  },
   "rules": {
     "no-unused-variable": true
   }

test/rules/no-unused-variable/ignore-pattern/tsconfig.json

@@ -0,0 +1,5 @@
+{
+    "compilerOptions": {
+        "module": "commonjs"
+    }
+}

test/rules/no-unused-variable/ignore-pattern/tslint.json

@@ -1,7 +1,4 @@
 {
-  "linterOptions": {
-    "typeCheck": true
-  },
   "rules": {
     "no-unused-variable": [true, {"ignore-pattern": "^[_R]"}]
   }

test/rules/no-unused-variable/type-checked/tslint.json

@@ -1,7 +1,4 @@
 {
-  "linterOptions": {
-    "typeCheck": true
-  },
   "rules": {
     "no-unused-variable": true
   }

test/rules/no-use-before-declare/tsconfig.json

@@ -0,0 +1,5 @@
+{
+    "compilerOptions": {
+        "module": "commonjs"
+    }
+}

test/rules/no-use-before-declare/tslint.json

@@ -1,7 +1,4 @@
 {
-  "linterOptions": {
-    "typeCheck": true
-  },
   "rules": {
     "no-use-before-declare": true
   }

test/rules/no-void-expression/default/tslint.json

@@ -1,7 +1,4 @@
 {
-  "linterOptions": {
-    "typeCheck": true
-  },
   "rules": {
     "no-void-expression": true
   }

test/rules/no-void-expression/ignore-arrow-function-shorthand/tsconfig.json

@@ -0,0 +1,5 @@
+{
+    "compilerOptions": {
+        "module": "commonjs"
+    }
+}