Skip to content

Commit

Permalink
mailbox: always wait in mbox_send_message for blocking Tx mode
Browse files Browse the repository at this point in the history
There exists a race when msg_submit return immediately as there was an
active request being processed which may have completed just before it's
checked again in mbox_send_message. This will result in return to the
caller without waiting in mbox_send_message even when it's blocking Tx.

This patch fixes the issue by waiting for the completion always if Tx
is in blocking mode.

Fixes: 2b6d83e ("mailbox: Introduce framework for mailbox")
Reported-by: Alexey Klimov <[email protected]>
Signed-off-by: Sudeep Holla <[email protected]>
Reviewed-by: Alexey Klimov <[email protected]>
Signed-off-by: Jassi Brar <[email protected]>
  • Loading branch information
sudeep-holla authored and JassiBrar committed Apr 27, 2017
1 parent 7387491 commit c61b781
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/mailbox/mailbox.c
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ int mbox_send_message(struct mbox_chan *chan, void *mssg)

msg_submit(chan);

if (chan->cl->tx_block && chan->active_req) {
if (chan->cl->tx_block) {
unsigned long wait;
int ret;

Expand Down

0 comments on commit c61b781

Please sign in to comment.