reducing healthcheck metrics

api/health/service.go

@@ -7,14 +7,13 @@ import (
 	"net/http"
 	"time"
 
-	stdjson "encoding/json"
-
 	"github.com/ava-labs/avalanchego/snow/engine/common"
 	"github.com/ava-labs/avalanchego/utils/json"
 	"github.com/ava-labs/avalanchego/utils/logging"
 	"github.com/gorilla/rpc/v2"
 	"github.com/prometheus/client_golang/prometheus"
 
+	stdjson "encoding/json"
 	health "github.com/AppsFlyer/go-sundheit"
 	healthlib "github.com/ava-labs/avalanchego/health"
 )

health/metrics.go

@@ -4,11 +4,11 @@
 package health
 
 import (
-	health "github.com/AppsFlyer/go-sundheit"
-	"github.com/prometheus/client_golang/prometheus"
-
 	"github.com/ava-labs/avalanchego/utils/logging"
 	"github.com/ava-labs/avalanchego/utils/wrappers"
+	"github.com/prometheus/client_golang/prometheus"
+
+	health "github.com/AppsFlyer/go-sundheit"
 )
 
 // metrics reports commonly used health check metrics.
@@ -40,7 +40,7 @@ func newMetrics(log logging.Logger, namespace string, registerer prometheus.Regi
 
 // healthy handles the metrics for the healthy cases
 func (m *metrics) healthy(health.Result) {
-	m.failingChecks.Dec()
+	m.failingChecks.Set(0)
 }
 
 // unHealthy handles the metrics for the unhealthy cases

vms/platformvm/health.go

@@ -23,7 +23,7 @@ func (vm *VM) HealthCheck() (interface{}, error) {
 		"percentConnected": percentConnected,
 	}
 	if percentConnected < constants.MinConnectedStake { // Use alpha from consensus instead of const
-		return details, fmt.Errorf("not connected to enough stake - connected to %f percent of the stake; should be connected to at least %f",
+		return details, fmt.Errorf("connected to %f percent of the stake; should be connected to at least %f",
 			percentConnected,
 			constants.MinConnectedStake,
 		)