Token reconstruction runtime sets #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: fent <[email protected]>
Co-authored-by: fent <[email protected]>
Co-authored-by: fent <[email protected]>
…ocal_token_reconstruction Merging changes from typescript conversion branch
Co-authored-by: fent <[email protected]>
Needed to make importing using the syntax shown in the README valid
Co-authored-by: Charmander <[email protected]>
Co-authored-by: fent <[email protected]>
Merged
|
why create a new PR? the other PR contains lots of discussion that could be useful when looking it over in the future. if it was the last commits you were going to revert, you can submit reverted commits. you can also force push those commits out of history if you wanted to keep history clean |
|
I'd checked out a new branch at the commit I wanted to revert back to and worked from there so it seemed cleaner to pull the new branch. I have now pushed those changes onto the existing token-reconstruction branch and reponed the respective PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.