Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use promise #2

Closed
wants to merge 1 commit into from

Conversation

christophehurpeau
Copy link

modern browsers have promises
You could also add a link to https://cdn.polyfill.io/v2/polyfill.min.js?features=Promise for those who need it.

This is a breaking change.

modern browsers have promises
You could also add a link to https://cdn.polyfill.io/v2/polyfill.min.js?features=Promise for those who need it.

This is a breaking change.
@feross
Copy link
Owner

feross commented Jun 11, 2017

Thanks for the PR! I prefer callbacks. Maybe once async-await ships in browsers, I will reconsider this PR. In the meantime, feel free to wrap this in a promise.

@feross feross closed this Jun 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants