Allow functions to be inlined #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You are so right I completely forgot about that. I am rewriting most of the crate for v3 so I think this PR is about to extremely Not Apply (sorry) but I will definitely take your advice and publish updates on the earlier series as well. Thanks for the PR, and I'm sorry about (a) the long delay and (b) the ... having done it myself before I saw this, and therefore not merging :/ I do appreciate the effort though, sincerely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that functions in this crate aren't being inlined in generated code, which comes with a severe performance penalty given how tiny some of these functions are. This PR adds
#[inline(always)]annotations to the trait implementations to prevent this from happening.I also noticed that funty 2.0 hasn't yet been pushed to GitHub, so this PR is against version 1.2. Given how commonly older versions of funty are used in the wild (based on crates.io download stats) and also the performance implications, this fix should probably be backported to 1.1, 1.2, and 2.0 branches.