Skip to content

Commit

Permalink
nfsd: depend on CRYPTO_MD5 for legacy client tracking
Browse files Browse the repository at this point in the history 
The legacy client tracking infrastructure of nfsd makes use of MD5 to
derive a client's recovery directory name. As the nfsd module doesn't
declare any dependency on CRYPTO_MD5, though, it may fail to allocate
the hash if the kernel was compiled without it. As a result, generation
of client recovery directories will fail with the following error:

    NFSD: unable to generate recoverydir name

The explicit dependency on CRYPTO_MD5 was removed as redundant back in
6aaa67b (NFSD: Remove redundant "select" clauses in fs/Kconfig
2008-02-11) as it was already implicitly selected via RPCSEC_GSS_KRB5.
This broke when RPCSEC_GSS_KRB5 was made optional for NFSv4 in commit
df486a2 (NFS: Fix the selection of security flavours in Kconfig) at
a later point.

Fix the issue by adding back an explicit dependency on CRYPTO_MD5.

Fixes: df486a2 (NFS: Fix the selection of security flavours in Kconfig)
Signed-off-by: Patrick Steinhardt <[email protected]>
Signed-off-by: J. Bruce Fields <[email protected]>
  • Loading branch information
@pks-t
pks-t authored and J. Bruce Fields committed Dec 7, 2019
1 parent 18f428d commit 38a2204
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions fs/nfsd/Kconfig
View file
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ config NFSD_V4
select NFSD_V3
select FS_POSIX_ACL
select SUNRPC_GSS
select CRYPTO_MD5
select CRYPTO_SHA256
select GRACE_PERIOD
help
Expand Down

0 comments on commit 38a2204

Please sign in to comment.