Skip to content

Commit

Permalink
Merge pull request cloudflare#21 from lukeed/chore/semver
Browse files Browse the repository at this point in the history
chore: swap semver -> semiver
  • Loading branch information
mrbbot authored Jul 30, 2021
2 parents fec3372 + c1f97e2 commit 9083131
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
"node-cron": "^2.0.3",
"sanitize-filename": "^1.6.3",
"selfsigned": "^1.10.11",
"semver": "^7.3.5",
"semiver": "^1.1.0",
"source-map-support": "^0.5.19",
"tslib": "^2.3.0",
"typescript": "^4.3.4",
Expand All @@ -71,7 +71,6 @@
"@types/node-cron": "^2.0.3",
"@types/node-forge": "^0.10.2",
"@types/rimraf": "^3.0.0",
"@types/semver": "^7.3.7",
"@types/source-map-support": "^0.5.3",
"@types/which": "^2.0.0",
"@types/ws": "^7.4.5",
Expand Down
4 changes: 2 additions & 2 deletions src/cli.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { promises as fs } from "fs";
import path from "path";
import fetch from "@mrbbot/node-fetch";
import envPaths from "env-paths";
import semverGt from "semver/functions/gt";
import semiver from "semiver";
import yargs from "yargs";
import { ConsoleLog, Log } from "./log";
import {
Expand Down Expand Up @@ -276,7 +276,7 @@ export async function updateCheck({
await fs.writeFile(lastCheckFile, now.toString(), "utf8");

// Log version if latest version is greater than the currently installed
if (semverGt(registryVersion, pkg.version)) {
if (semiver(registryVersion, pkg.version) > 0) {
log.warn(
[
`Miniflare ${registryVersion} is available,`,
Expand Down

0 comments on commit 9083131

Please sign in to comment.