Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use clang-format with Qt style #63

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

alexfikl
Copy link
Contributor

@alexfikl alexfikl commented Mar 17, 2024

The Qt style was copied from https://code.qt.io/cgit/qt/qt5.git/tree/_clang-format
There's also a KDE style at https://invent.kde.org/frameworks/extra-cmake-modules/-/blob/master/kde-modules/clang-format.cmake

Applied using

fd -e h -x clang-format -i
fd -e cpp -x clang-format -i

@alexfikl
Copy link
Contributor Author

I'm not a big Qt/C++ programmer these days, so I don't have a preference besides just having some consistent formatting. We can use another .clang-format config if that fits better with the project.

@alexfikl
Copy link
Contributor Author

@jfmcarreira (soft ping) Have you had a chance to look at this?

@jfmcarreira
Copy link
Collaborator

I was not fully aware the lack of formatting rules in this repository. We can go with this one. And thanks for the ping, as I had forgot it

@jfmcarreira jfmcarreira merged commit 2573e41 into fhackenberger:master Apr 16, 2024
2 checks passed
@alexfikl alexfikl deleted the clang-format branch April 16, 2024 16:10
@alexfikl
Copy link
Contributor Author

I was not fully aware the lack of formatting rules in this repository. We can go with this one. And thanks for the ping, as I had forgot it

No worries and thank you for merging this! 🎉

For what it's worth, the codebase seemed pretty consistent, but I'm not sure what style it was using. This looks like a lot of changes because it used tabs instead of spaces for indentation.. so pretty much every line was changed :\

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants