Skip to content

Commit

Permalink
Fix PR18162 - Incorrect assertion assumed that the SDValue resno is z…
Browse files Browse the repository at this point in the history
…ero.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@196858 91177308-0d34-0410-b5e6-96231b3b80d8
  • Loading branch information
nadavrot committed Dec 10, 2013
1 parent d5cf7ab commit 6806e11
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 1 deletion.
2 changes: 1 addition & 1 deletion lib/CodeGen/SelectionDAG/DAGCombiner.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -9859,7 +9859,7 @@ SDValue DAGCombiner::visitCONCAT_VECTORS(SDNode *N) {
if (N->getNumOperands() == 2 &&
N->getOperand(1)->getOpcode() == ISD::UNDEF) {
SDValue In = N->getOperand(0);
assert(In->getValueType(0).isVector() && "Must concat vectors");
assert(In.getValueType().isVector() && "Must concat vectors");

// Transform: concat_vectors(scalar, undef) -> scalar_to_vector(sclr).
if (In->getOpcode() == ISD::BITCAST &&
Expand Down
27 changes: 27 additions & 0 deletions test/CodeGen/X86/pr18162.ll
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
; RUN: llc < %s

; Make sure we are not crashing on this one.

target triple = "x86_64-unknown-linux-gnu"

%"Iterator" = type { i32* }

declare { i64, <2 x float> } @Call()
declare { i64, <2 x float> }* @CallPtr()

define { i64, <2 x float> } @Foo(%"Iterator"* %this) {
entry:
%retval = alloca i32
%this.addr = alloca %"Iterator"*
%this1 = load %"Iterator"** %this.addr
%bundle_ = getelementptr inbounds %"Iterator"* %this1, i32 0, i32 0
%0 = load i32** %bundle_
%1 = call { i64, <2 x float> } @Call()
%2 = call { i64, <2 x float> }* @CallPtr()
%3 = getelementptr { i64, <2 x float> }* %2, i32 0, i32 1
%4 = extractvalue { i64, <2 x float> } %1, 1
store <2 x float> %4, <2 x float>* %3
%5 = load { i64, <2 x float> }* %2
ret { i64, <2 x float> } %5
}

0 comments on commit 6806e11

Please sign in to comment.