Skip to content

Commit

Permalink
Build LLVM with -Wstrict-prototypes enabled
Browse files Browse the repository at this point in the history
Clang 5 supports -Wstrict-prototypes. We should use it to catch any C
declarations that declare a non-prototype function.

rdar://33705313

Differential Revision: https://reviews.llvm.org/D36669


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@312240 91177308-0d34-0410-b5e6-96231b3b80d8
  • Loading branch information
hyp committed Aug 31, 2017
1 parent 2464521 commit adeedb1
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions cmake/modules/HandleLLVMOptions.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -581,6 +581,8 @@ if (LLVM_ENABLE_WARNINGS AND (LLVM_COMPILER_IS_GCC_COMPATIBLE OR CLANG_CL))

# Enable -Wstring-conversion to catch misuse of string literals.
add_flag_if_supported("-Wstring-conversion" STRING_CONVERSION_FLAG)
# Enable -Wstrict-prototypes to catch incorrectly declared functions in C.
add_flag_if_supported("-Wstrict-prototypes" STRICT_PROTOTYPES_FLAG)
endif (LLVM_ENABLE_WARNINGS AND (LLVM_COMPILER_IS_GCC_COMPATIBLE OR CLANG_CL))

if (LLVM_COMPILER_IS_GCC_COMPATIBLE AND NOT LLVM_ENABLE_WARNINGS)
Expand Down

0 comments on commit adeedb1

Please sign in to comment.