Skip to content

Commit

Permalink
Revert r312240
Browse files Browse the repository at this point in the history
The buildbots have shown that -Wstrict-prototypes behaves differently in GCC
and Clang so we should keep it disabled until Clang follows GCC's behaviour


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@312246 91177308-0d34-0410-b5e6-96231b3b80d8
  • Loading branch information
hyp committed Aug 31, 2017
1 parent a8bf892 commit b7d233e
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions cmake/modules/HandleLLVMOptions.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -581,8 +581,6 @@ if (LLVM_ENABLE_WARNINGS AND (LLVM_COMPILER_IS_GCC_COMPATIBLE OR CLANG_CL))

# Enable -Wstring-conversion to catch misuse of string literals.
add_flag_if_supported("-Wstring-conversion" STRING_CONVERSION_FLAG)
# Enable -Wstrict-prototypes to catch incorrectly declared functions in C.
add_flag_if_supported("-Wstrict-prototypes" STRICT_PROTOTYPES_FLAG)
endif (LLVM_ENABLE_WARNINGS AND (LLVM_COMPILER_IS_GCC_COMPATIBLE OR CLANG_CL))

if (LLVM_COMPILER_IS_GCC_COMPATIBLE AND NOT LLVM_ENABLE_WARNINGS)
Expand Down

0 comments on commit b7d233e

Please sign in to comment.