Skip to content

Commit

Permalink
dts: bindings: add missing pinctrl-device.yaml includes
Browse files Browse the repository at this point in the history
These worked because edtlib allows 'pinctrl-.*' properties without
specifying them on the bindings. However, this has never been an
anounced pinctrl feature, the reference documents explicitly mention
that usage of pinctrl-device.yaml is mandatory.

Signed-off-by: Gerard Marull-Paretas <[email protected]>
  • Loading branch information
gmarull authored and carlescufi committed Sep 27, 2023
1 parent e0a0b35 commit ad08b3c
Show file tree
Hide file tree
Showing 8 changed files with 8 additions and 21 deletions.
2 changes: 1 addition & 1 deletion dts/bindings/dac/nxp,lpdac.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ description: NXP MCUX LPDAC

compatible: "nxp,lpdac"

include: dac-controller.yaml
include: [dac-controller.yaml, pinctrl-device.yaml]

properties:
reg:
Expand Down
2 changes: 1 addition & 1 deletion dts/bindings/i2c/sifive,i2c0.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ description: SiFive Freedom I2C interface

compatible: "sifive,i2c0"

include: i2c-controller.yaml
include: [i2c-controller.yaml, pinctrl-device.yaml]

properties:
reg:
Expand Down
3 changes: 1 addition & 2 deletions dts/bindings/i2c/telink,b91-i2c.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

description: Telink B91 I2C

include: i2c-controller.yaml
include: [i2c-controller.yaml, pinctrl-device.yaml]

compatible: "telink,b91-i2c"

Expand All @@ -12,5 +12,4 @@ properties:
required: true

pinctrl-0:
type: phandles
required: true
3 changes: 1 addition & 2 deletions dts/bindings/pwm/telink,b91-pwm.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,13 @@

description: Telink B91 PWM

include: [pwm-controller.yaml, base.yaml]
include: [pwm-controller.yaml, pinctrl-device.yaml, base.yaml]

compatible: "telink,b91-pwm"

properties:

pinctrl-0:
type: phandles
required: true

clock-frequency:
Expand Down
2 changes: 1 addition & 1 deletion dts/bindings/serial/quicklogic,usbserialport_s3b.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ description: QuickLogic USBserialport_S3B serial interface

compatible: "quicklogic,usbserialport-s3b"

include: uart-controller.yaml
include: [uart-controller.yaml, pinctrl-device.yaml]

properties:
reg:
Expand Down
3 changes: 1 addition & 2 deletions dts/bindings/serial/telink,b91-uart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ description: Telink B91 UART

compatible: "telink,b91-uart"

include: uart-controller.yaml
include: [uart-controller.yaml, pinctrl-device.yaml]

properties:
reg:
Expand All @@ -15,5 +15,4 @@ properties:
required: true

pinctrl-0:
type: phandles
required: true
3 changes: 1 addition & 2 deletions dts/bindings/spi/telink,b91-spi.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

description: Telink B91 SPI

include: spi-controller.yaml
include: [spi-controller.yaml, pinctrl-device.yaml]

compatible: "telink,b91-spi"

Expand All @@ -19,7 +19,6 @@ properties:
- "HSPI_MODULE"

pinctrl-0:
type: phandles
required: true

cs0-pin:
Expand Down
11 changes: 1 addition & 10 deletions dts/bindings/test/vnd,adc-temp-sensor.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ description: Test ADC-based temperature sensor

compatible: "vnd,adc-temp-sensor"

include: [base.yaml, reset-device.yaml]
include: [base.yaml, pinctrl-device.yaml, reset-device.yaml]

properties:
io-channels:
Expand All @@ -18,12 +18,3 @@ properties:

clocks:
required: true

pinctrl-0:
type: phandles

pinctrl-1:
type: phandles

pinctrl-2:
type: phandles

0 comments on commit ad08b3c

Please sign in to comment.