fix(fcm): Wrap HTTP/2 session errors in promise #2868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
lahirumaramba
approved these changes
Mar 14, 2025
| // Start session listeners | ||
| http2SessionHandler.invoke().catch((error) => { | ||
| const pendingBatchResponse = | ||
| sendResponsePromise ? sendResponsePromise.then(this.parseSendResponses) : undefined; |
There was a problem hiding this comment.
Just thinking out loud, if a session error occurs before any of the requests have gone through would pendingBatchResponse be undefined?
There was a problem hiding this comment.
Yes, this would be undefined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RELEASE NOTE: Fixed a issue which caused session errors not to be thrown.
FirebaseMessagingSessionErrorpendingBatchResponsefield to newFirebaseMessagingSessionErrorto allow access to the status of messages which were in flight at error time.