feat(py): generate types.py from genkit-schema.json using datamodel-codegen #1807 #1808
+585
−249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yesudeep
force-pushed
the
yesudeep/feat/big-ticket
branch
from
5cbb967 to
8959150
Compare
yesudeep
changed the title
yesudeep
force-pushed
the
yesudeep/feat/big-ticket
branch
from
8959150 to
2c1dd96
Compare
apascal07
reviewed
Feb 3, 2025
| ) | ||
| text: Any | None = None | ||
| media: Any | None = None | ||
| toolRequest: Any | None = None |
There was a problem hiding this comment.
Ignore if this is still in progress/intentional, but these types look off?
There was a problem hiding this comment.
Weird. This is autogenerated, but let me take a look.
pavelgj
reviewed
Feb 3, 2025
| from pydantic import BaseModel, ConfigDict, Field, RootModel | ||
|
|
||
|
|
||
| class Model(RootModel[Any]): |
There was a problem hiding this comment.
Could you please double check, but I believe this one was causing runtime errors before. Had to manually remove it.
pavelgj
approved these changes
Feb 3, 2025
apascal07
reviewed
Feb 3, 2025
| totalTokens: float | None = None | ||
| inputCharacters: float | None = None | ||
| outputCharacters: float | None = None | ||
| inputImages: float | None = None |
yesudeep
force-pushed
the
yesudeep/feat/big-ticket
branch
5 times, most recently
from
b24d67f to
7723ab8
Compare
…el-codegen #1807 ISSUE: #1807 CHANGELOG: - [ ] Add a bin/generate_schema_types script that generates the Pydantic types.py module. - [ ] Update the pre-commit hooks to ensure this file gets regenerated routinely. - [ ] Remove timestamp to ensure we do not treat a file with identical content differently preventing the hassles of updating this file per commit.
yesudeep
force-pushed
the
yesudeep/feat/big-ticket
branch
from
7723ab8 to
2735ceb
Compare
pavelgj
reviewed
Feb 4, 2025
| index: float | ||
| message: Message | ||
| usage: Optional[GenerationUsage] = None | ||
| usage: GenerationUsage | None = None |
There was a problem hiding this comment.
just a question: is GenerationUsage | None preferable to Optional[GenerationUsage]?
There was a problem hiding this comment.
It's the same thing in Python. The newer way of writing this is using type unions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: generate
types.pyfromgenkit-schema.jsonusing datamodel-codegen #1807ISSUE: #1807
CHANGELOG:
types.py module.
routinely.
content differently preventing the hassles of updating this file per
commit.
Checklist (if applicable):