Skip to content

Commit

Permalink
packages/firmata.js: remove "browser-serialport" support (unmaintaine…
Browse files Browse the repository at this point in the history
…d since 2016)
  • Loading branch information
rwaldron committed Jan 15, 2019
1 parent c34b728 commit c12eb79
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 11 deletions.
15 changes: 5 additions & 10 deletions packages/firmata.js/lib/com.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,17 +40,12 @@ let SerialPort;
let stub = Stub;

try {
/* istanbul ignore if */
if (process.browser || parseFloat(process.versions.nw) >= 0.13) {
com = require("browser-serialport");
/* istanbul ignore else */
if (process.env.IS_TEST_MODE) {
com = stub;
} else {
/* istanbul ignore else */
if (process.env.IS_TEST_MODE) {
com = stub;
} else {
SerialPort = require("serialport");
com = SerialPort;
}
SerialPort = require("serialport");
com = SerialPort;
}
} catch (err) {
error = err;
Expand Down
1 change: 0 additions & 1 deletion packages/firmata.js/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
"main": "./lib/firmata",
"devDependencies": {},
"dependencies": {
"browser-serialport": "latest",
"firmata-io": "^2.0.0",
"serialport": "^7.1.1"
},
Expand Down

0 comments on commit c12eb79

Please sign in to comment.