Arrays to buffers #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erial port on travis.
…s to buffers but other output streams do not.
…uire array functions to operate.
jgautier
added a commit
that referenced
this pull request
Sep 11, 2013
Looks good thanks! Also thanks for fixing travis.
| this.lastWrite = buffer; | ||
| this.emit('write', buffer); | ||
|
|
||
| this.emit('write', buffer); | ||
| }; |
There was a problem hiding this comment.
These changes need to make their way to Johnny-Five as well.
There was a problem hiding this comment.
For the record, we landed something else instead, we now check to see if we're calling firmata correctly instead of spying on what firmata is doing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change our writes to use buffers instead of arrays so node Writable streams don't complain. We haven't seen this issue with
node-serialportbecause it auto converts arrays to buffers but other output streams do not.I rebased this branch off of #43 and make the necessary changes so the tests won't break. This was needed because tests use
Array#indexOfa lot.