Skip to content

Commit

Permalink
Use towncrier to build the changelog (matrix-org#3425)
Browse files Browse the repository at this point in the history
  • Loading branch information
hawkowl authored Jun 25, 2018
1 parent 33fdcfa commit 36cb570
Show file tree
Hide file tree
Showing 20 changed files with 55 additions and 1 deletion.
10 changes: 9 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,12 @@ language: python
# tell travis to cache ~/.cache/pip
cache: pip

before_script:
- git remote set-branches --add origin develop
- git fetch origin develop

matrix:
fast_finish: true
include:
- python: 2.7
env: TOX_ENV=packaging
Expand All @@ -14,10 +19,13 @@ matrix:

- python: 2.7
env: TOX_ENV=py27

- python: 3.6
env: TOX_ENV=py36

- python: 3.6
env: TOX_ENV=check-newsfragment

install:
- pip install tox

Expand Down
20 changes: 20 additions & 0 deletions CONTRIBUTING.rst
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,26 @@ Please ensure your changes match the cosmetic style of the existing project,
and **never** mix cosmetic and functional changes in the same commit, as it
makes it horribly hard to review otherwise.

Changelog
~~~~~~~~~

All changes, even minor ones, need a corresponding changelog
entry. These are managed by Towncrier
(https://github.com/hawkowl/towncrier).

To create a changelog entry, make a new file in the ``changelog.d``
file named in the format of ``issuenumberOrPR.type``. The type can be
one of ``feature``, ``bugfix``, ``removal`` (also used for
deprecations), or ``misc`` (for internal-only changes). The content of
the file is your changelog entry, which can contain RestructuredText
formatting. A note of contributors is welcomed in changelogs for
non-misc changes (the content of misc changes is not displayed).

For example, a fix for a bug reported in #1234 would have its
changelog entry in ``changelog.d/1234.bugfix``, and contain content
like "The security levels of Florbs are now validated when
recieved over federation. Contributed by Jane Matrix".

Attribution
~~~~~~~~~~~

Expand Down
3 changes: 3 additions & 0 deletions MANIFEST.in
Original file line number Diff line number Diff line change
Expand Up @@ -29,5 +29,8 @@ exclude Dockerfile
exclude .dockerignore
recursive-exclude jenkins *.sh

include pyproject.toml
recursive-include changelog.d *

prune .github
prune demo/etc
1 change: 1 addition & 0 deletions changelog.d/3324.removal
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Remove was_forgotten_at
1 change: 1 addition & 0 deletions changelog.d/3327.bugfix
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Strip access_token from outgoing requests
Empty file added changelog.d/3332.misc
Empty file.
1 change: 1 addition & 0 deletions changelog.d/3334.feature
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Cache factor override system for specific caches
1 change: 1 addition & 0 deletions changelog.d/3340.doc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
``doc/postgres.rst``: fix display of the last command block. Thanks to @ArchangeGabriel!
Empty file added changelog.d/3341.misc
Empty file.
1 change: 1 addition & 0 deletions changelog.d/3344.feature
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add metrics to track appservice transactions
Empty file added changelog.d/3347.misc
Empty file.
Empty file added changelog.d/3348.misc
Empty file.
1 change: 1 addition & 0 deletions changelog.d/3349.bugfix
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Redact AS tokens in logs
1 change: 1 addition & 0 deletions changelog.d/3355.bugfix
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix federation backfill from SQLite servers
Empty file added changelog.d/3356.misc
Empty file.
1 change: 1 addition & 0 deletions changelog.d/3363.bugfix
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix event-purge-by-ts admin API
1 change: 1 addition & 0 deletions changelog.d/3371.bugfix
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix event filtering in get_missing_events handler
1 change: 1 addition & 0 deletions changelog.d/3372.feature
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Try to log more helpful info when a sig verification fails
5 changes: 5 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
[tool.towncrier]
package = "synapse"
filename = "CHANGES.rst"
directory = "changelog.d"
issue_format = "`#{issue} <https://github.com/matrix-org/synapse/issues/{issue}>`_"
8 changes: 8 additions & 0 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -102,3 +102,11 @@ basepython = python2.7
deps =
flake8
commands = /bin/sh -c "flake8 synapse tests {env:PEP8SUFFIX:}"


[testenv:check-newsfragment]
skip_install = True
deps = towncrier>=18.6.0rc1
commands =
python -m towncrier.check --compare-with=origin/develop
basepython = python3.6

0 comments on commit 36cb570

Please sign in to comment.