Skip to content

Commit

Permalink
MDL-41410 Caching: move comment to the appropriate place.
Browse files Browse the repository at this point in the history
MDL-38162 fixes the issue about testing the connection to the memcached
daemon, which means testing once the connection to the pool of servers
and not to each of the servers while being added to the pool.
It misses to move the comment to that code too.
  • Loading branch information
scara committed Aug 25, 2013
1 parent d2aa53b commit a94bc88
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion cache/stores/memcache/lib.php
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,8 @@ public function __construct($name, array $configuration = array()) {
$this->connection = new Memcache;
foreach ($this->servers as $server) {
$this->connection->addServer($server[0], $server[1], true, $server[2]);
// Test the connection to this server.
}
// Test the connection to the pool of servers.
$this->isready = @$this->connection->set($this->parse_key('ping'), 'ping', MEMCACHE_COMPRESSED, 1);
}

Expand Down
1 change: 1 addition & 0 deletions cache/stores/memcached/lib.php
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ public function __construct($name, array $configuration = array()) {
}
$this->connection->addServers($this->servers);
}
// Test the connection to the pool of servers.
$this->isready = @$this->connection->set("ping", 'ping', 1);
}

Expand Down

0 comments on commit a94bc88

Please sign in to comment.