Skip to content
This repository has been archived by the owner on Oct 25, 2024. It is now read-only.

Add option to submit blocks only with bundles #16

Closed

Conversation

adrianchifor
Copy link

@adrianchifor adrianchifor commented Dec 3, 2022

Adding an extra option on miner so we can skip building blocks to relays if they don't include any bundles. Mempool-only blocks with naive algos like greedy or mev-geth are not competitive enough to get bought in the majority of cases, and they can become spammy on relays if more people start running builders.

--miner.only_bundle_blocks     (default: false)
          Build only blocks with bundles

cc @avalonche @Ruteri


@Ruteri
Copy link
Collaborator

Ruteri commented Dec 3, 2022

If the flag were on the miner config, you could avoid all the computation as you already know you can't build a block as soon as txpool.MevBundles call. I think it's worth it, as we anyway have builder-specific miner flags. what do you think?

@adrianchifor
Copy link
Author

If the flag were on the miner config, you could avoid all the computation as you already know you can't build a block as soon as txpool.MevBundles call. I think it's worth it, as we anyway have builder-specific miner flags. what do you think?

Nice good point, updated to miner.

Copy link
Collaborator

@Ruteri Ruteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to cover all places where MevBundles is called (one more fillTransactionsAlgoWorker or something).

cmd/utils/flags.go Outdated Show resolved Hide resolved
@adrianchifor adrianchifor force-pushed the onlyBlocksWithBundles branch from ca8396c to 4789e42 Compare January 2, 2023 17:28
@adrianchifor adrianchifor requested a review from Ruteri January 2, 2023 17:34
@adrianchifor adrianchifor deleted the onlyBlocksWithBundles branch January 13, 2023 12:16
avalonche pushed a commit that referenced this pull request Feb 7, 2023
avalonche pushed a commit that referenced this pull request Mar 9, 2023
avalonche pushed a commit that referenced this pull request Mar 15, 2023
avalonche pushed a commit that referenced this pull request Mar 17, 2023
avalonche pushed a commit that referenced this pull request Mar 22, 2023
avalonche pushed a commit that referenced this pull request Jul 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants