Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faheelsattar/random coinbase address #335

Merged
merged 3 commits into from
Jan 6, 2025
Merged

Faheelsattar/random coinbase address #335

merged 3 commits into from
Jan 6, 2025

Conversation

faheelsattar
Copy link
Contributor

@faheelsattar faheelsattar commented Jan 2, 2025 •
edited
Loading

📝 Summary

Generates a random coinbase address if none was set
Closes #306

💡 Motivation and Context

✅ I have completed the following steps:

  • Run make lint
  • Run make test
  • Added tests (if applicable)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025 •
edited
Loading

Benchmark results for c20b964

Report: https://flashbots-rbuilder-ci-stats.s3.us-east-2.amazonaws.com/benchmark/c20b964-026df71/report/index.html
Date (UTC) 2025-01-05T16:41:03+00:00
Commit c20b964559900f2529139c42252789bf97f56587
Base SHA 026df71fdf2c8c6f6740682b6358d02f0e14bc09

Significant changes

Benchmark Mean Status
ptr_trie_insert_only_3000 -6.80% Performance has improved.
gather_nodes_big_changes_account 2.28% Performance has degraded.
gather_nodes_storage_tries -7.14% Performance has improved.
MEV-Boost SubmitBlock serialization/JSON encoding -35.14% Performance has improved.

ferranbt
ferranbt requested changes Jan 4, 2025
View reviewed changes
Copy link
Contributor

@ferranbt ferranbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nitpicks.

crates/rbuilder/src/live_builder/base_config.rs Outdated Show resolved Hide resolved
liamaharon
liamaharon reviewed Jan 4, 2025
View reviewed changes
Copy link
Contributor

@liamaharon liamaharon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like a potential footgun.

Is there a legitimate reason an L1 builder would not want to specify the coinbase address?

@faheelsattar faheelsattar requested a review from ferranbt January 5, 2025 11:28
@ferranbt ferranbt merged commit 798de18 into flashbots:develop Jan 6, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamaharon liamaharon liamaharon left review comments

@ferranbt ferranbt ferranbt approved these changes

@dvush dvush Awaiting requested review from dvush dvush is a code owner

@ZanCorDX ZanCorDX Awaiting requested review from ZanCorDX ZanCorDX is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate a random coinbase address if none found
3 participants
@faheelsattar @liamaharon @ferranbt