Rework security labels for devices #2574
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonnyp
force-pushed
the
reword-device-labels
branch
from
68b5b14 to
21fbf0e
Compare
bertob
reviewed
Feb 10, 2024
| @@ -402,8 +402,8 @@ | |||
| "has-network-access": "Has network access", | |||
| "uses-system-services": "Uses system services", | |||
| "uses-session-services": "Uses session services", | |||
| "can-access-hardware-devices": "Can access hardware devices such as webcams or gaming controllers", | |||
| "can-access-input-devices": "Can access input devices such as keyboards, mice or gaming controllers", | |||
| "can-access-all-devices": "Can access all devices such as webcams, microphones or keyboards", | |||
There was a problem hiding this comment.
Suggested change
| "can-access-all-devices": "Can access all devices such as webcams, microphones or keyboards", | |
| "can-access-all-devices": "Can access all devices such as webcams, microphones, or keyboards", |
|
I think this will blow up the weblate repo, I usually try to only edit the main translation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"can-access-hardware-devices" is incorrect for
device=allsince it allows access to emulated/"software" devices as wellThe label for
can-access-input-devicesis incorrect.--device=inputdoesn't allow access to keyboard and mices. See https://gitlab.gnome.org/GNOME/epiphany/-/merge_requests/1428#note_1993226It's mostly useful for gamepads and usb gadgets