-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The get_info API returns run_statuses and end_statuses. #1862
base: pre/2.8
Are you sure you want to change the base?
Conversation
08db8bf
to
0de3a1f
Compare
0de3a1f
to
996baa5
Compare
8bfa01a
to
7f248d5
Compare
7f248d5
to
9d87959
Compare
@momchil-flex @lei-flex There are some change, could you double check? |
9d87959
to
0bd6a72
Compare
Note that tests are failing @QimingFlex . Otherwise not sure what comments @lei-flex had on the code and if they are resolved. |
Could you clarify if this is related to me or if any action is needed on my part? |
Sorry @QimingFlex I keep tagging you when I mean Qingeng (@magiWei ) |
maybe it's due to to this? |
0bd6a72
to
905b4e9
Compare
@tylerflex @momchil-flex I have rebased the pre/2.8 to my branch, but the UT also fails, I don't know what happened, the error: `Error: Submodule docs/faq is not up to date. Please update it. Error: Process completed with exit code 1.` |
80aeb0d
to
753a31e
Compare
753a31e
to
8a547dd
Compare
You can ignore that test if everything else passes, main question now is if @lei-flex and @tylerflex's comments have been well addressed. |
@magiWei any updates on this? last I remember, lei and I had some comments. is this PR still worth trying to merge? |
No description provided.