Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The get_info API returns run_statuses and end_statuses. #1862

Open
wants to merge 1 commit into
base: pre/2.8
Choose a base branch
from

Conversation

magiWei
Copy link

@magiWei magiWei commented Jul 30, 2024

No description provided.

@magiWei magiWei force-pushed the feature_status_return branch from 08db8bf to 0de3a1f Compare July 30, 2024 01:40
@magiWei magiWei force-pushed the feature_status_return branch from 0de3a1f to 996baa5 Compare July 30, 2024 01:56
tidy3d/web/api/container.py Show resolved Hide resolved
tidy3d/web/api/container.py Show resolved Hide resolved
tidy3d/web/api/container.py Show resolved Hide resolved
@magiWei magiWei force-pushed the feature_status_return branch 2 times, most recently from 8bfa01a to 7f248d5 Compare July 31, 2024 05:28
@momchil-flex
Copy link
Collaborator

Is this meant to be ready @magiWei @lei-flex

@magiWei
Copy link
Author

magiWei commented Aug 16, 2024

Is this meant to be ready @magiWei @lei-flex

No, @LeiZheng still has a different opinion.

@magiWei magiWei force-pushed the feature_status_return branch from 7f248d5 to 9d87959 Compare August 16, 2024 07:04
@magiWei
Copy link
Author

magiWei commented Aug 16, 2024

@momchil-flex @lei-flex There are some change, could you double check?

@magiWei magiWei force-pushed the feature_status_return branch from 9d87959 to 0bd6a72 Compare August 16, 2024 07:09
@momchil-flex
Copy link
Collaborator

Note that tests are failing @QimingFlex . Otherwise not sure what comments @lei-flex had on the code and if they are resolved.

@QimingFlex
Copy link
Contributor

Note that tests are failing @QimingFlex . Otherwise not sure what comments @lei-flex had on the code and if they are resolved.

Could you clarify if this is related to me or if any action is needed on my part?

@momchil-flex
Copy link
Collaborator

Sorry @QimingFlex I keep tagging you when I mean Qingeng (@magiWei )

tidy3d/web/api/container.py Outdated Show resolved Hide resolved
tidy3d/web/api/container.py Outdated Show resolved Hide resolved
tidy3d/web/core/system_config.py Outdated Show resolved Hide resolved
tidy3d/web/core/system_config.py Outdated Show resolved Hide resolved
tidy3d/web/core/system_config.py Outdated Show resolved Hide resolved
@tylerflex
Copy link
Collaborator

Note that tests are failing @QimingFlex . Otherwise not sure what comments @lei-flex had on the code and if they are resolved.

maybe it's due to to this?

@magiWei magiWei force-pushed the feature_status_return branch from 0bd6a72 to 905b4e9 Compare August 22, 2024 09:17
@magiWei
Copy link
Author

magiWei commented Aug 23, 2024

@tylerflex @momchil-flex I have rebased the pre/2.8 to my branch, but the UT also fails, I don't know what happened, the error:

`Error: Submodule docs/faq is not up to date. Please update it.

Error: Process completed with exit code 1.`

@magiWei magiWei force-pushed the feature_status_return branch 3 times, most recently from 80aeb0d to 753a31e Compare August 23, 2024 08:43
@magiWei magiWei force-pushed the feature_status_return branch from 753a31e to 8a547dd Compare August 23, 2024 09:52
@momchil-flex
Copy link
Collaborator

@tylerflex @momchil-flex I have rebased the pre/2.8 to my branch, but the UT also fails, I don't know what happened, the error:

`Error: Submodule docs/faq is not up to date. Please update it.

Error: Process completed with exit code 1.`

You can ignore that test if everything else passes, main question now is if @lei-flex and @tylerflex's comments have been well addressed.

@tylerflex
Copy link
Collaborator

@magiWei any updates on this? last I remember, lei and I had some comments. is this PR still worth trying to merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants