Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simpler CR model demo #11

Merged
merged 3 commits into from
Apr 4, 2018
Merged

Simpler CR model demo #11

merged 3 commits into from
Apr 4, 2018

Conversation

fujiisoup
Copy link
Collaborator

We already have CRmodel demo in demo/FeL, but it takes very long calculation time and thus it is not suitable for the daily testing / checking.

I would like to have much simpler demo (like He-like lithium) for the testing purpose.

Any comments would be appreciated.

@QuantumGuy
Copy link

QuantumGuy commented Apr 4, 2018 via email

@fujiisoup
Copy link
Collaborator Author

@QuantumGuy

Thanks your comment.

BTW, some python package which used in the demo is a little outdated, for
example, biglless package. It doesn't work in some case. If it is possible,
the matplotlib could be used instead of biglles.

Yes. This is in the second line of my TODO list.
My first TODO is setting up an automatic checking system whether any new modification would break the code accidentally (this sometimes happen as can be seen in #10 ).

But As I can see, He-like
Li might be too simple. It can not provide the user with enough information
to learn.

Agreed. I want this just for testing purpose not for giving users to a good example.
demo directory may not be a suitable one to keep this example.
I can move this into tests directory.

@QuantumGuy
Copy link

QuantumGuy commented Apr 4, 2018 via email

@fujiisoup fujiisoup mentioned this pull request Apr 4, 2018
Merged
@fujiisoup
Copy link
Collaborator Author

I notice that even a CR model for He-like Lithium takes too much time for the daily testing.
I think we need a further simpler model...

@mfgu
Copy link
Collaborator

mfgu commented Apr 4, 2018

you are including too many levels. just try the example i provided at iaea website. the d.py and s.py files there.

@fujiisoup
Copy link
Collaborator Author

fujiisoup commented Apr 4, 2018 •
edited
Loading

Thanks. It looks a nice example not only for the testing but also for users.
I will update this PR later.

fujiisoup added 2 commits April 4, 2018 14:14
@fujiisoup
Added a lithium CR model demo
a56e0d3 
openmp parallization of rmatrix module

remove duplicate omp private variable in rmatirx

fix openmp segfault in structure

Remove Li crmodel. Added Ne crm.
@fujiisoup
Merge branch 'master' into li_crm
68c0759
@fujiisoup fujiisoup changed the title A lithium CR model demo More simpler CR model demo Apr 4, 2018
@fujiisoup fujiisoup changed the title More simpler CR model demo Simpler CR model demo Apr 4, 2018
@fujiisoup
Copy link
Collaborator Author

I took a script from the IAEA website. The tests are now passing.
If there is no objection, I will merge this tomorrow.

@fujiisoup fujiisoup merged commit f095caf into flexible-atomic-code:master Apr 4, 2018
@fujiisoup fujiisoup deleted the li_crm branch April 4, 2018 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fujiisoup @QuantumGuy @mfgu