fix broken ppol module #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
April 4, 2018 11:48
Merge branch 'master' of https://github.com/flexible-atomic-code/fac
Merge branch 'master' of https://github.com/flexible-atomic-code/fac
Merge branch 'master' of https://github.com/flexible-atomic-code/fac
Merge branch 'master' of https://github.com/flexible-atomic-code/fac
Merge branch 'master' of https://github.com/flexible-atomic-code/fac
Merge branch 'master' of https://github.com/flexible-atomic-code/fac
|
Thanks. It was my mistake. |
|
you don't check the pol.txt or pop.txt files.
…On Mon, Apr 9, 2018 at 10:08 PM, Keisuke Fujii ***@***.***> wrote:
Thanks. It was my mistake.
I am curious why the tests were passing...
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMnr8Sxvupq47KYwnkWmVZzKlMWCeKQkks5tnBQhgaJpZM4TLkbf>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the ppol module initialization was broken when python 3 support was introduced.