Improves transaction rollback handling #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlavelle
commented
Dec 5, 2024
orville-postgresql/src/Orville/PostgreSQL/Execution/Transaction.hs
Outdated
Show resolved
Hide resolved
orville-postgresql/src/Orville/PostgreSQL/Execution/Transaction.hs
Outdated
Show resolved
Hide resolved
telser
reviewed
Dec 6, 2024
orville-postgresql/src/Orville/PostgreSQL/Execution/Transaction.hs
Outdated
Show resolved
Hide resolved
telser
reviewed
Dec 6, 2024
orville-postgresql/src/Orville/PostgreSQL/Execution/Transaction.hs
Outdated
Show resolved
Hide resolved
ysangkok
reviewed
Dec 6, 2024
orville-postgresql/src/Orville/PostgreSQL/Execution/Transaction.hs
Outdated
Show resolved
Hide resolved
jbrechtel
reviewed
Dec 6, 2024
orville-postgresql/src/Orville/PostgreSQL/Execution/Transaction.hs
Outdated
Show resolved
Hide resolved
orville-postgresql/src/Orville/PostgreSQL/Execution/Transaction.hs
Outdated
Show resolved
Hide resolved
I added exception handling around the success event SQL execution in `finishTransaction` in `withTransaction`. If a `SqlExecutionError` occurs, it will run the rollback callback and rethrow the exception. I also added libpq transaction status checks to `beginTransaction` and `finishTransaction` in `withTransaction`. If the status is unexpected for a given transaction event, `withTransaction` will throw an `UnexpectedTransactionStatusError`.
jlavelle
force-pushed
the
nebula/improve-transaction-rollbacks
branch
from
a6c350e to
e08919c
Compare
telser
reviewed
Dec 23, 2024
telser
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added exception handling around the success event SQL execution in
finishTransactioninwithTransaction. If aSqlExecutionErroroccurs, it will run the rollback callback and rethrow the exception.I also added libpq transaction status checks to
beginTransactionandfinishTransactioninwithTransaction. If the status is unexpected for a given transaction event,withTransactionwill throw anUnexpectedTransactionStatusError.