fix(audit): allow to send events with complex payload to kafka with avro #3827
+183
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3827 +/- ##
==========================================
+ Coverage 64.80% 64.86% +0.06%
==========================================
Files 171 171
Lines 17387 17397 +10
==========================================
+ Hits 11267 11284 +17
+ Misses 5423 5415 -8
- Partials 697 698 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There is no easy way to provide all possible schemas for event payload. As workaround if the payload map have complex type it will be converted into json string if avro encoding is enabled. Signed-off-by: Roman Dmytrenko <[email protected]>
erka
force-pushed
the
rd/audit-kafka-avro
branch
from
f891367 to
f9765ee
Compare
dosubot
bot
added
the
size:L
markphelps
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no easy way to provide all possible schemas for event payload.
As workaround if the payload map have complex type it will be converted
into json string if avro encoding is enabled.
fixes #3825