Skip to content

Commit

Permalink
Update BOLT references with typo fixes.
Browse files Browse the repository at this point in the history
Signed-off-by: Rusty Russell <[email protected]>
  • Loading branch information
rustyrussell authored and cdecker committed Oct 10, 2017
1 parent 52f741d commit e137e25
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 8 deletions.
2 changes: 1 addition & 1 deletion channeld/channel.c
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ static void send_announcement_signatures(struct peer *peer)
/* BOLT #7:
*
* If sent, `announcement_signatures` messages MUST NOT be sent until
* `funding_locked` has been sent, and the funding transaction is has
* `funding_locked` has been sent and the funding transaction has
* at least 6 confirmations.
*/
if (!(peer->announce_depth_reached && peer->funding_locked[LOCAL]))
Expand Down
3 changes: 2 additions & 1 deletion channeld/full_channel.c
Original file line number Diff line number Diff line change
Expand Up @@ -518,7 +518,8 @@ enum channel_remove_err channel_fulfill_htlc(struct channel *channel,
* based on: */
/* BOLT #2:
*
* A node MUST NOT send `update_fulfill_htlc` until an HTLC is
* A node MUST NOT send an `update_fulfill_htlc`, `update_fail_htlc`
* or `update_fail_malformed_htlc` until the corresponding HTLC is
* irrevocably committed in both sides' commitment transactions.
*/
if (htlc->state == SENT_ADD_ACK_REVOCATION)
Expand Down
2 changes: 1 addition & 1 deletion common/cryptomsg.c
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ static void maybe_rotate_key(u64 *n, struct secret *k, struct secret *ck)

/* BOLT #8:
*
* A key is to be rotated after a party sends of decrypts
* A key is to be rotated after a party sends or decrypts
* `1000` messages with it. This can be properly accounted
* for by rotating the key once the nonce dedicated to it
* exceeds `1000`.
Expand Down
2 changes: 1 addition & 1 deletion common/initial_channel.h
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ struct channel {

/* BOLT #2:
*
* `dust_limit_satoshis` is the threshold below which output should be
* `dust_limit_satoshis` is the threshold below which outputs should not be
* generated for this node's commitment or HTLC transaction */
static inline u64 dust_limit_satoshis(const struct channel *channel,
enum side side)
Expand Down
4 changes: 2 additions & 2 deletions lightningd/test/run-funding_tx.c
Original file line number Diff line number Diff line change
Expand Up @@ -68,14 +68,14 @@ int main(void)
assert(input);

/* BOLT #3:
* Block 1 coinbase privkey: 6bd078650fcee8444e4e09825227b801a1ca928debb750eb36e6d56124bb20e80101
* Block 1 coinbase privkey: 6bd078650fcee8444e4e09825227b801a1ca928debb750eb36e6d56124bb20e801
* # privkey in base58: cRCH7YNcarfvaiY1GWUKQrRGmoezvfAiqHtdRvxe16shzbd7LDMz
*/
if (!key_from_base58("cRCH7YNcarfvaiY1GWUKQrRGmoezvfAiqHtdRvxe16shzbd7LDMz", strlen("cRCH7YNcarfvaiY1GWUKQrRGmoezvfAiqHtdRvxe16shzbd7LDMz"),
&testnet, &input_privkey, &inputkey))
abort();
assert(testnet);
printf("* Block 1 coinbase privkey: %s01\n",
printf("* Block 1 coinbase privkey: %s\n",
type_to_string(tmpctx, struct privkey, &input_privkey));

/* BOLT #3:
Expand Down
2 changes: 1 addition & 1 deletion onchaind/onchain.c
Original file line number Diff line number Diff line change
Expand Up @@ -863,7 +863,7 @@ static void handle_preimage(struct tracked_output **outs,
/* BOLT #5:
*
* To spend an offered HTLC output: if the transaction is the
* nodes' own commitment transaction, then it MUST use the
* node's own commitment transaction, then it MUST use the
* HTLC-success transaction, and the HTLC-success transaction
* output MUST be *resolved* as described in "On-chain HTLC
* Transaction Handling"
Expand Down
2 changes: 1 addition & 1 deletion openingd/opening.c
Original file line number Diff line number Diff line change
Expand Up @@ -497,7 +497,7 @@ static u8 *fundee_channel(struct state *state,

/* BOLT #2:
*
* The receiving MUST reject the channel if the `chain_hash` value
* The receiving node MUST reject the channel if the `chain_hash` value
* within the `open_channel` message is set to a hash of a chain
* unknown to the receiver.
*/
Expand Down

0 comments on commit e137e25

Please sign in to comment.