Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to deflake service isolate startup #35950

Merged
merged 1 commit into from
Sep 6, 2022
Merged

Conversation

dnfield
Copy link
Contributor

@dnfield dnfield commented Sep 6, 2022

Speculative fix for flutter/flutter#106753

Re-orders the call to making the isolate runnable to the end, after we set the private fields.

Tested this locally and it seems to work fine, but I had not reproduced the flake locally.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Contributor

@bkonyi bkonyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, may as well give it a shot :)

@Hixie
Copy link
Contributor

Hixie commented Sep 6, 2022

test-exempt: fixing a test

@a-siva
Copy link
Contributor

a-siva commented Sep 7, 2022

Did this change actually deflake the service isolate startup issue ?
The call to Dart_IsolateMakeRunnable only sets the runnable state of the isolate, the isolate itself is scheduled for execution on the thread pool after this callback returns.

@dnfield
Copy link
Contributor Author

dnfield commented Sep 7, 2022

No, this did not seem to have any impact on the flake.

Oleh-Sv pushed a commit to Oleh-Sv/engine that referenced this pull request Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants