[android] Add HC++ platform view controller. #56776
Open
+2,041
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahwilliams
changed the title
johnmccutchan
approved these changes
Dec 16, 2024
| @@ -1129,7 +1129,8 @@ public void attachToFlutterEngine(@NonNull FlutterEngine flutterEngine) { | |||
| this, | |||
| this.flutterEngine.getTextInputChannel(), | |||
| this.flutterEngine.getScribeChannel(), | |||
| this.flutterEngine.getPlatformViewsController()); | |||
| this.flutterEngine.getPlatformViewsController(), | |||
There was a problem hiding this comment.
Unrelated to your change- would probably be simpler to just pass flutterEngine into this call?
|
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hybrid composition++ has an entirely different mechanism for compositing than the previous approach. To that end, its much simpler to devise a second platform view controller than to add a 4th mechanism to the existing nightmare class.
This change does not actually wire up the new platform view controller to the engine, nor does it add a mechanism for enabling/disabling the new platform views code. This logic should be mostly inert, but I'd prefer to start checking it in now.