-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[in_app_purchase_storekit] Add support to win back offers / promotional offers #8474
base: main
Are you sure you want to change the base?
[in_app_purchase_storekit] Add support to win back offers / promotional offers #8474
Conversation
…ffers
…2-win-back-offers' into feature/in-app-purchase-storekit2-win-back-offers
Hey just letting you know Ive looked at your PR, and it looks really good! I've checked out your branch and it seems to work well locally. However our tests are failing to compile because currently they're running on ios 17.0. I'm taking a look to see if theres a way around this, but if you want to try building your branch on Xcode 15 or lower that would be really helpful too! |
Thanks for for testing it locally It seems we’re currently blocked by flutter/flutter#148870. Also, I think we should add a CHANGELOG warning regarding this Xcode requirement. Maybe an |
…se-storekit2-win-back-offers # Conflicts: # packages/in_app_purchase/in_app_purchase_storekit/CHANGELOG.md
…ffers
Hi @LouiseHsu, when you have a moment, could you please take a look at this PR? Thanks |
…ffers
purchaseOptions.insert(.appAccountToken(accountTokenUUID)) | ||
} | ||
|
||
#if compiler(>=6.0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe an #if compiler directive could help here, but I haven’t tested it yet, so I’m not sure if it actually works. Let me know what you think
We should not land code that does not compile in our CI. For example, we have no way of knowing whether these tests will actually pass in our CI, meaning they could block future Xcode updates, and we also aren't actually getting any test coverage that would prevent landing a future PR that breaks this new code or the associated tests.
If the feature requires an SDK version we don't yet have in CI, we need to wait for that SDK to be in CI to proceed.
Adds StoreKit2 support for:
checkWinBackOfferEligibility
method for eligibility checksappAccountToken
handling for StoreKit2 purchasesFixes:
flutter/flutter#161393
flutter/flutter#160826
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///
).