Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main #44

Merged
merged 4 commits into from
Jan 12, 2021
Merged

Main #44

merged 4 commits into from
Jan 12, 2021

Conversation

bbolker
Copy link
Contributor

@bbolker bbolker commented Jan 4, 2021

With the move to GitHub actions I changed skip_on_travis() to skip_on_ci() throughout. I also commented out the scheduled cron test in the workflow (seems like overkill).

I am still having problems passing devtools tests; I think these may be due to sporadic network access problems? Ran devtools::test() twice in a row. First time results were

[ FAIL 4 | WARN 1 | SKIP 1 | PASS 100 ]

second time was

[ FAIL 1 | WARN 1 | SKIP 1 | PASS 110 ]

I don't know if there's a way to make the tests more robust or not (I also noticed that on GitHub actions a different subset of platforms would fail each time ...

@fmichonneau fmichonneau merged commit 8dad7bf into fmichonneau:main Jan 12, 2021
@fmichonneau
Copy link
Owner

the tests produce some false positive because of difference in caching between the data scrapped from the CRAN website and the RDS database that holds the results of the tests. For a few days the number of failing tests was much higher than usual (maybe because of the CRAN vacation?). Things are still not perfect but back to usual lower levels of errors. I want to keep to run the tests regularly on the main repo as it helps me detect when things change on CRAN's side but maybe I could update the GitHub actions file to have the cron jobs not run in forks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants