Fix for many CRAN mirrors #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This first commit address problem 1 in issue #63. Prior to this fix, we have: After fixing we have: This resolves the test in issue #63 for a large number of mirrors, but not all: Coverage is now up from ~19% to ~36%. |
… URL>/package=<pkg>
|
This second commit address problem 2 in issue #63. Prior to this fix, we have: However, clicking this link reveals the mirror does not redirect such URLs: https://cran.asia/package=mlmc. After fixing we have: This full package URL is supported by the mirror, try clicking: https://cran.asia/web/packages/mlmc/index.html This resolves the test in issue #63 for nearly all mirrors: Coverage is now up from ~19% (pre this PR) to ~97% following both commits. Investigations into the mirrors still failing revealed:
This means foghorn's forced use of SSL is the only real remaining problem from issue #63 and that only affects 2 mirrors (the third simply having an expired certificate). Therefore, if the maintainers are happy then I think merging this PR would resolve the issue I opened! Hope that helps, Louis |
|
Thanks for the fixes @louisaslett! I'm surprised that mirrors don't support the canonical URL format required by CRAN, but your fix makes sense. It would be great to add a test to make sure we account for these mirrors. Is it something you'd be able to do? Thanks again! |
Agreed, I was surprised too. Since writing the issue+PR, I spotted that the canonical URL format is listed under "Optional server configuration" on the CRAN Mirror FAQ, so it seems less than half of mirrors do this optional step sadly.
I'd be happy to have a go at putting some test together, though I'm not completely sure I understand. Do you mean have the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to address problems 1 and 2 described in issue #63.
I will update this PR thread with the revised results of running the test given in the above issue.