libvirt: Drop default authentication params

Previously we used hard-coded credentials when connecting to the default libvirtd instance. This patch is dropping these params, to just not be opinionated. Fixes kubevirt#21.
fnet123 · Jan 4, 2017 · f890bce · f890bce
1 parent ac44290
commit f890bce
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/cmd/virt-handler/virt-handler.go b/cmd/virt-handler/virt-handler.go
@@ -24,8 +24,8 @@ func main() {
 
 	libvirtapi.EventRegisterDefaultImpl()
 	libvirtUri := flag.String("libvirt-uri", "qemu:///system", "Libvirt connection string.")
-	libvirtUser := flag.String("user", "vdsm@ovirt", "Libvirt user")
-	libvirtPass := flag.String("pass", "shibboleth", "Libvirt password")
+	libvirtUser := flag.String("user", "", "Libvirt user")
+	libvirtPass := flag.String("pass", "", "Libvirt password")
 	host := flag.String("hostname-override", "", "Kubernetes Pod to monitor for changes")
 	flag.Parse()
 

diff --git a/images/libvirtd/Dockerfile b/images/libvirtd/Dockerfile
@@ -13,8 +13,6 @@ RUN yum install -y \
 COPY augconf /augconf
 RUN augtool -f /augconf
 
-RUN echo -n shibboleth | saslpasswd2 -p -a libvirt vdsm@ovirt
-
 COPY libvirtd.sh /libvirtd.sh
 RUN chmod a+x /libvirtd.sh
 #EXPOSE 16509

diff --git a/images/libvirtd/augconf b/images/libvirtd/augconf
@@ -1,7 +1,7 @@
 # Enable unauthenticated tcp
 set /files/etc/libvirt/libvirtd.conf/listen_tls 0
 set /files/etc/libvirt/libvirtd.conf/listen_tcp 1
-set /files/etc/libvirt/libvirtd.conf/auth_tcp sasl
+set /files/etc/libvirt/libvirtd.conf/auth_tcp none
 
 # Listen on all interfaces for now
 set /files/etc/libvirt/qemu.conf/spice_listen 0.0.0.0