Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): add type class for 'dev' key #1873

Closed
wants to merge 1 commit into from
Closed

Conversation

dsully
Copy link
Contributor

@dsully dsully commented Jan 3, 2025

Description

The dev options key is no longer a boolean.

@dsully dsully changed the title fix: Add type class for 'dev' key. fix(types): Add type class for 'dev' key Jan 3, 2025
@dsully dsully changed the title fix(types): Add type class for 'dev' key fix(types): add type class for 'dev' key Jan 3, 2025
@folke
Copy link
Owner

folke commented Jan 5, 2025

This is not correct. The dev prop for a plugin spec should always be a boolean.

@folke folke closed this Jan 5, 2025
@dsully
Copy link
Contributor Author

dsully commented Jan 5, 2025

Hi @folke - this isn't for the a plugin spec, but for Lazy's config itself. Perhaps I did this in the wrong place?

@folke
Copy link
Owner

folke commented Jan 5, 2025

You added it for the plugin spec.
It is already correct for the lazy config

@dsully
Copy link
Contributor Author

dsully commented Jan 5, 2025

Screenshot 2025-01-05 at 5 16 05 AM

lua-language-server seems to disagree.. 😎

@max397574
Copy link
Contributor

seems like a lua-ls issue

@dsully
Copy link
Contributor Author

dsully commented Jan 5, 2025

Thanks for the pointer - turns out it was misplaced ---@type LazyConfig

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants