Skip to content

Commit

Permalink
Merge branch 'master' into compat-test
Browse files Browse the repository at this point in the history
  • Loading branch information
amilajack committed Dec 30, 2016
2 parents c97414a + c9b28f0 commit 0cce3a6
Show file tree
Hide file tree
Showing 4 changed files with 112 additions and 87 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ See [electron-builder CLI Usage](https://github.com/electron-userland/electron-b

#### Module Structure

This boilerplate uses a [two package.json structure](https://github.com/electron-userland/electron-builder#two-packagejson-structure).
This boilerplate uses a [two package.json structure](https://github.com/electron-userland/electron-builder/wiki/Two-package.json-Structure).

1. If the module is native to a platform or otherwise should be included with the published package (i.e. bcrypt, openbci), it should be listed under `dependencies` in `./app/package.json`.
2. If a module is `import`ed by another module, include it in `dependencies` in `./package.json`. See [this ESLint rule](https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-extraneous-dependencies.md).
Expand Down
Empty file removed app/api/.gitkeep
Empty file.
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"start": "cross-env NODE_ENV=production electron ./app/",
"flow-typed-install": "flow-typed install",
"start-hot": "cross-env HOT=1 NODE_ENV=development electron -r babel-register -r babel-polyfill ./app/main.development",
"postinstall": "concurrently \"npm run flow-typed-install\" \"install-app-deps\" \"node node_modules/fbjs-scripts/node/check-dev-engines.js package.json\"",
"postinstall": "concurrently \"install-app-deps\" \"node node_modules/fbjs-scripts/node/check-dev-engines.js package.json\"",
"dev": "npm run hot-server -- --start-hot",
"package": "npm run build && build --publish never",
"package-win": "npm run build && build --win --x64",
Expand Down Expand Up @@ -153,7 +153,7 @@
"webpack": "^1.14.0",
"webpack-dev-middleware": "^1.9.0",
"webpack-hot-middleware": "^2.13.2",
"webpack-merge": "^1.1.2",
"webpack-merge": "^2.0.0",
"webpack-validator": "^2.3.0"
},
"dependencies": {
Expand Down
Loading

0 comments on commit 0cce3a6

Please sign in to comment.