Skip to content

Commit

Permalink
Use dependencies of app/package.json as webpack externals
Browse files Browse the repository at this point in the history
  • Loading branch information
jhen0409 committed Nov 12, 2016
1 parent a538224 commit aa27996
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 9 deletions.
1 change: 0 additions & 1 deletion app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,5 @@
},
"license": "MIT",
"dependencies": {
"source-map-support": "^0.4.3"
}
}
8 changes: 4 additions & 4 deletions webpack.config.base.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@

import path from 'path';
import validate from 'webpack-validator';
import {
dependencies as externals
} from './app/package.json';

export default validate({
module: {
Expand Down Expand Up @@ -33,8 +36,5 @@ export default validate({

plugins: [],

externals: [
// put your node 3rd party libraries which can't be built with webpack here
// (mysql, mongodb, and so on..)
]
externals: Object.keys(externals || {})
});
4 changes: 0 additions & 4 deletions webpack.config.electron.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,4 @@ export default validate(merge(baseConfig, {
__dirname: false,
__filename: false
},

externals: [
// 'source-map-support'
]
}));

0 comments on commit aa27996

Please sign in to comment.