Revert over-eager bailout when trailing whitespace (microsoft#28848)

foreverI68 · Dec 4, 2018 · ee987a2 · ee987a2
1 parent c85460b
commit ee987a2
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 4 deletions.
diff --git a/src/services/formatting/formatting.ts b/src/services/formatting/formatting.ts
@@ -1106,10 +1106,7 @@ namespace ts.formatting {
          * Trimming will be done for lines after the previous range
          */
         function trimTrailingWhitespacesForRemainingRange() {
-            if (!previousRange) {
-                return;
-            }
-            const startPosition = previousRange.end;
+            const startPosition = previousRange ? previousRange.end : originalRange.pos;
 
             const startLine = sourceFile.getLineAndCharacterOfPosition(startPosition).line;
             const endLine = sourceFile.getLineAndCharacterOfPosition(originalRange.end).line;

diff --git a/tests/cases/fourslash/formatAfterWhitespace.ts b/tests/cases/fourslash/formatAfterWhitespace.ts
@@ -0,0 +1,14 @@
+/// <reference path="fourslash.ts" />
+////function foo()
+////{
+////    var bar;
+////    /*1*/
+////}
+goTo.marker('1')
+edit.insertLine("");
+verify.currentFileContentIs(`function foo()
+{
+    var bar;
+
+
+}`);