Skip to content

Commit

Permalink
leds: lp50xx: Remove unused field 'num_of_banked_leds' from 'struct l…
Browse files Browse the repository at this point in the history
…p50xx'

In 'struct lp50xx', the 'num_of_banked_leds' field is only written and
is never used. Moreover, storing such an information in the 'priv'
structure looks pointless, so remove it.

Signed-off-by: Christophe JAILLET <[email protected]>
Link: https://lore.kernel.org/r/a0d472ff587d13a2b91ec32c8776061019caab6a.1714324500.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Lee Jones <[email protected]>
  • Loading branch information
tititiou36 authored and lag-linaro committed May 2, 2024
1 parent 221db01 commit dd66d05
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions drivers/leds/leds-lp50xx.c
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,6 @@ struct lp50xx_led {
* @dev: pointer to the devices device struct
* @lock: lock for reading/writing the device
* @chip_info: chip specific information (ie num_leds)
* @num_of_banked_leds: holds the number of banked LEDs
* @leds: array of LED strings
*/
struct lp50xx {
Expand All @@ -289,7 +288,6 @@ struct lp50xx {
struct device *dev;
struct mutex lock;
const struct lp50xx_chip_info *chip_info;
int num_of_banked_leds;

/* This needs to be at the end of the struct */
struct lp50xx_led leds[];
Expand Down Expand Up @@ -403,8 +401,6 @@ static int lp50xx_probe_leds(struct fwnode_handle *child, struct lp50xx *priv,
return -EINVAL;
}

priv->num_of_banked_leds = num_leds;

ret = fwnode_property_read_u32_array(child, "reg", led_banks, num_leds);
if (ret) {
dev_err(priv->dev, "reg property is missing\n");
Expand Down

0 comments on commit dd66d05

Please sign in to comment.