Skip to content

Commit

Permalink
feat(chore): upgrade to rc4, upgrade tests
Browse files Browse the repository at this point in the history
  • Loading branch information
sonicoder86 committed Jul 9, 2016
1 parent e92a8f8 commit cba9784
Show file tree
Hide file tree
Showing 11 changed files with 64 additions and 58 deletions.
3 changes: 1 addition & 2 deletions .eslintrc
Original file line number Diff line number Diff line change
Expand Up @@ -363,9 +363,8 @@
"describe": true,
"it": true,
"inject": true,
"injectAsync": true,
"beforeEach": true,
"beforeEachProviders": true,
"addProviders": true,
"spyOn": true,
"expect": true,
"global": true,
Expand Down
18 changes: 10 additions & 8 deletions client/app/auth/components/login/login.component.spec.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { TestComponentBuilder } from '@angular/compiler/testing';
import { TestComponentBuilder } from '@angular/core/testing';
import { FormBuilder } from '@angular/common';
import { HTTP_PROVIDERS } from '@angular/http';
import { Observable } from 'rxjs/Observable';
Expand All @@ -18,13 +18,15 @@ describe('LoginComponent', () => {
let subjectElement;
let credentials = { email: '[email protected]', password: 'secret' };

beforeEachProviders(() => [
TestComponentBuilder,
FormBuilder,
HTTP_PROVIDERS,
AUTH_TESTING_PROVIDERS,
CORE_TESTING_PROVIDERS
]);
beforeEach(() => {
addProviders([
TestComponentBuilder,
FormBuilder,
HTTP_PROVIDERS,
AUTH_TESTING_PROVIDERS,
CORE_TESTING_PROVIDERS
]);
});

beforeEach(async(inject([TestComponentBuilder], (componentBuilder) => {
return componentBuilder
Expand Down
7 changes: 3 additions & 4 deletions client/app/auth/services/request/request.service.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,9 @@ import { StorageService } from '../storage/storage.service';
describe('RequestService', () => {
let subject;

beforeEachProviders(() => [
RequestService,
StorageService
]);
beforeEach(() => {
addProviders([RequestService, StorageService]);
});

beforeEach(inject([RequestService], (request) => {
subject = request;
Expand Down
6 changes: 3 additions & 3 deletions client/app/auth/services/storage/storage.service.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ describe('StorageService', () => {
spyOn(localStorage, 'removeItem');
});

beforeEachProviders(() => [
StorageService
]);
beforeEach(() => {
addProviders([StorageService]);
});

beforeEach(inject([StorageService], (storage) => {
subject = storage;
Expand Down
14 changes: 8 additions & 6 deletions client/app/auth/services/user/user.service.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,14 @@ describe('UserService', () => {
.respond(200, JSON.stringify({ success: true, auth_token: 'secret_token' }));
}

beforeEachProviders(() => [
UserService,
StorageService,
RequestService,
FAKE_BACKEND_PROVIDERS
]);
beforeEach(() => {
addProviders([
UserService,
StorageService,
RequestService,
FAKE_BACKEND_PROVIDERS
]);
});

beforeEach(inject([Injector], (injector) => {
subject = injector.get(UserService);
Expand Down
8 changes: 4 additions & 4 deletions client/app/core/components/about/about.component.spec.js
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
import { TestComponentBuilder } from '@angular/compiler/testing';
import { TestComponentBuilder } from '@angular/core/testing';

import { AboutComponent } from './about.component';

describe('AboutComponent', () => {
let subjectElement;

beforeEachProviders(() => [
TestComponentBuilder
]);
beforeEach(() => {
addProviders([TestComponentBuilder]);
});

beforeEach(async(inject([TestComponentBuilder], (componentBuilder) => {
return componentBuilder
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { FormBuilder } from '@angular/common';
import { Injector, Component, EventEmitter } from '@angular/core';
import { TestComponentBuilder } from '@angular/compiler/testing';
import { TestComponentBuilder } from '@angular/core/testing';

import { PostFormComponent } from './post-form.component';

Expand Down Expand Up @@ -42,7 +42,9 @@ describe('FormComponent', () => {
expect(element.querySelector('#post-description').value).toBe(examplePost.description);
}

beforeEachProviders(() => [TestComponentBuilder, FormBuilder]);
beforeEach(() => {
addProviders([TestComponentBuilder, FormBuilder]);
});

beforeEach(inject([Injector], (injector) => {
builder = injector.get(TestComponentBuilder);
Expand Down
6 changes: 4 additions & 2 deletions client/app/posts/pipes/short-description.pipe.spec.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { Component } from '@angular/core';
import { TestComponentBuilder } from '@angular/compiler/testing';
import { TestComponentBuilder } from '@angular/core/testing';

import { ShortDescriptionPipe } from './short-description.pipe';

Expand All @@ -24,7 +24,9 @@ describe('ShortDescriptionPipe', () => {
let pipe;
let builder;

beforeEachProviders(() => [ShortDescriptionPipe, TestComponentBuilder]);
beforeEach(() => {
addProviders([ShortDescriptionPipe, TestComponentBuilder]);
});

beforeEach(inject([ShortDescriptionPipe, TestComponentBuilder], (descriptionPipe, componentBuilder) => {
pipe = descriptionPipe;
Expand Down
28 changes: 15 additions & 13 deletions client/app/posts/services/post/post.service.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,19 +36,21 @@ describe('PostService', () => {
});
}

beforeEachProviders(() => [
PostService,
MockBackend,
BaseRequestOptions,
AUTH_PROVIDERS,
{
provide: Http,
useFactory: (mokcBackend, defaultOptions) => {
return new Http(mokcBackend, defaultOptions);
},
deps: [MockBackend, BaseRequestOptions]
}
]);
beforeEach(() => {
addProviders([
PostService,
MockBackend,
BaseRequestOptions,
AUTH_PROVIDERS,
{
provide: Http,
useFactory: (mokcBackend, defaultOptions) => {
return new Http(mokcBackend, defaultOptions);
},
deps: [MockBackend, BaseRequestOptions]
}
]);
});

beforeEach(inject([Injector], (injector) => {
service = injector.get(PostService);
Expand Down
11 changes: 4 additions & 7 deletions client/test.boot.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,18 +4,15 @@ import {
TEST_BROWSER_DYNAMIC_PLATFORM_PROVIDERS, TEST_BROWSER_DYNAMIC_APPLICATION_PROVIDERS
} from '@angular/platform-browser-dynamic/testing';
import {
setBaseTestProviders,
afterEach, beforeEach, beforeEachProviders,
describe, it, expect,
inject, async, tick
setBaseTestProviders, addProviders,
inject, async
} from '@angular/core/testing';

setBaseTestProviders(TEST_BROWSER_DYNAMIC_PLATFORM_PROVIDERS, TEST_BROWSER_DYNAMIC_APPLICATION_PROVIDERS);

Object.assign(global, {
afterEach, beforeEach, beforeEachProviders,
describe, it, expect,
inject, async: async, tick
addProviders,
inject, async: async
});

let testContext = require.context('./app', true, /\.spec\.js/);
Expand Down
15 changes: 8 additions & 7 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,14 @@
"node-uuid": "1.4.7"
},
"devDependencies": {
"@angular/common": "2.0.0-rc.3",
"@angular/compiler": "2.0.0-rc.3",
"@angular/core": "2.0.0-rc.3",
"@angular/http": "2.0.0-rc.3",
"@angular/platform-browser": "2.0.0-rc.3",
"@angular/platform-browser-dynamic": "2.0.0-rc.3",
"@angular/router": "3.0.0-alpha.7",
"@angular/common": "2.0.0-rc.4",
"@angular/compiler": "2.0.0-rc.4",
"@angular/core": "2.0.0-rc.4",
"@angular/forms": "0.2.0",
"@angular/http": "2.0.0-rc.4",
"@angular/platform-browser": "2.0.0-rc.4",
"@angular/platform-browser-dynamic": "2.0.0-rc.4",
"@angular/router": "3.0.0-beta.2",
"babel-core": "6.10.4",
"babel-eslint": "6.1.1",
"babel-loader": "6.2.4",
Expand Down

0 comments on commit cba9784

Please sign in to comment.