Skip to content

Commit

Permalink
update minor api updates for github source. (knative#2100)
Browse files Browse the repository at this point in the history
  • Loading branch information
n3wscott authored and knative-prow-robot committed Jan 14, 2020
1 parent b3f4abf commit 97c84ad
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 7 deletions.
7 changes: 4 additions & 3 deletions docs/eventing/samples/github-source/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -133,9 +133,10 @@ spec:
name: githubsecret
key: secretToken
sink:
apiVersion: serving.knative.dev/v1
kind: Service
name: github-message-dumper
ref:
apiVersion: serving.knative.dev/v1
kind: Service
name: github-message-dumper
```

Then, apply that yaml using `kubectl`:
Expand Down
7 changes: 4 additions & 3 deletions docs/eventing/samples/github-source/github-source.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,9 @@ spec:
name: githubsecret
key: secretToken
sink:
apiVersion: serving.knative.dev/v1
kind: Service
name: github-message-dumper
ref:
apiVersion: serving.knative.dev/v1
kind: Service
name: github-message-dumper
# To use GitHub Enterprise you would need to add an entry for your githubAPIURL similar to the example below
# githubAPIURL: "https://github.mycompany.com/api/v3/"
2 changes: 1 addition & 1 deletion docs/eventing/samples/github-source/service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@ spec:
template:
spec:
containers:
- image: gcr.io/knative-releases/github.com/knative/eventing-sources/cmd/event_display
- image: gcr.io/knative-releases/github.com/knative/eventing-contrib/cmd/event_display

0 comments on commit 97c84ad

Please sign in to comment.