Fix the bug of plus operator (matrixorigin#2194)

foxxnuaa · Apr 12, 2022 · d7babd5 · d7babd5
1 parent ebb2eca
commit d7babd5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/pkg/sql/viewexec/oplus/oplus.go b/pkg/sql/viewexec/oplus/oplus.go
@@ -495,7 +495,7 @@ func (ctr *Container) fillH8(bat *batch.Batch, proc *process.Process) error {
 					if !nulls.Any(vecs[j].Nsp) {
 						for k := int64(0); k < n; k++ {
 							*(*int8)(unsafe.Add(unsafe.Pointer(&ctr.h8.keys[k]), ctr.keyOffs[k])) = 0
-							copy(unsafe.Slice((*byte)(unsafe.Pointer(&ctr.h8.keys[k])), 8)[ctr.keyOffs[k]:], vData[vOff[i+k]:vOff[i+k]+vLen[i+k]])
+							copy(unsafe.Slice((*byte)(unsafe.Pointer(&ctr.h8.keys[k])), 8)[ctr.keyOffs[k]+1:], vData[vOff[i+k]:vOff[i+k]+vLen[i+k]])
 							ctr.keyOffs[k] += vLen[i+k] + 1
 						}
 					} else {
@@ -776,7 +776,7 @@ func (ctr *Container) fillH8(bat *batch.Batch, proc *process.Process) error {
 				if !nulls.Any(vecs[j].Nsp) {
 					for k := int64(0); k < n; k++ {
 						*(*int8)(unsafe.Add(unsafe.Pointer(&ctr.h8.keys[k]), ctr.keyOffs[k])) = 0
-						copy(unsafe.Slice((*byte)(unsafe.Pointer(&ctr.h8.keys[k])), 8)[ctr.keyOffs[k]:], vData[vOff[i+k]:vOff[i+k]+vLen[i+k]])
+						copy(unsafe.Slice((*byte)(unsafe.Pointer(&ctr.h8.keys[k])), 8)[ctr.keyOffs[k]+1:], vData[vOff[i+k]:vOff[i+k]+vLen[i+k]])
 						ctr.keyOffs[k] += vLen[i+k] + 1
 					}
 				} else {

diff --git a/pkg/sql/viewexec/plus/plus.go b/pkg/sql/viewexec/plus/plus.go
@@ -487,7 +487,7 @@ func (ctr *Container) fillH8(bat *batch.Batch, proc *process.Process) error {
 				if !nulls.Any(vecs[j].Nsp) {
 					for k := int64(0); k < n; k++ {
 						*(*int8)(unsafe.Add(unsafe.Pointer(&ctr.h8.keys[k]), ctr.keyOffs[k])) = 0
-						copy(unsafe.Slice((*byte)(unsafe.Pointer(&ctr.h8.keys[k])), 8)[ctr.keyOffs[k]:], vData[vOff[i+k]:vOff[i+k]+vLen[i+k]])
+						copy(unsafe.Slice((*byte)(unsafe.Pointer(&ctr.h8.keys[k])), 8)[ctr.keyOffs[k]+1:], vData[vOff[i+k]:vOff[i+k]+vLen[i+k]])
 						ctr.keyOffs[k] += vLen[i+k] + 1
 					}
 				} else {