Skip to content

Commit

Permalink
Merge tag 'threads-v5.7' of git://git.kernel.org/pub/scm/linux/kernel…
Browse files Browse the repository at this point in the history
…/git/brauner/linux

Pull thread updates from Christian Brauner:
 "The main change for this cycle was the extension for clone3() to
  support spawning processes directly into cgroups via CLONE_INTO_CGROUP
  (commit ef2c41c: "clone3: allow spawning processes
  into cgroups").

  But since I had to touch kernel/cgroup/ quite a bit I had Tejun route
  that through his tree this time around to make it easier for him to
  handle other changes.

  So here is just the unexciting leftovers: a regression test for the
  ENOMEM regression we fixed in commit b26ebfe ("pid: Fix error
  return value in some cases") verifying that we report ENOMEM when
  trying to create a new process in a pid namespace whose init
  process/subreaper has already exited"

* tag 'threads-v5.7' of git://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux:
  selftests: add pid namespace ENOMEM regression test
  • Loading branch information
torvalds committed Apr 4, 2020
2 parents 2fb732b + 6952a4f commit 1e396a5
Show file tree
Hide file tree
Showing 7 changed files with 60 additions and 0 deletions.
1 change: 1 addition & 0 deletions MAINTAINERS
Original file line number Diff line number Diff line change
Expand Up @@ -13285,6 +13285,7 @@ S: Maintained
T: git git://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux.git
F: samples/pidfd/
F: tools/testing/selftests/pidfd/
F: tools/testing/selftests/pid_namespace/
F: tools/testing/selftests/clone3/
K: (?i)pidfd
K: (?i)clone3
Expand Down
1 change: 1 addition & 0 deletions tools/testing/selftests/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ TARGETS += net/mptcp
TARGETS += netfilter
TARGETS += nsfs
TARGETS += pidfd
TARGETS += pid_namespace
TARGETS += powerpc
TARGETS += proc
TARGETS += pstore
Expand Down
1 change: 1 addition & 0 deletions tools/testing/selftests/pid_namespace/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
regression_enomem
8 changes: 8 additions & 0 deletions tools/testing/selftests/pid_namespace/Makefile
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# SPDX-License-Identifier: GPL-2.0
CFLAGS += -g -I../../../../usr/include/

TEST_GEN_PROGS := regression_enomem

include ../lib.mk

$(OUTPUT)/regression_enomem: regression_enomem.c ../pidfd/pidfd.h
2 changes: 2 additions & 0 deletions tools/testing/selftests/pid_namespace/config
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
CONFIG_PID_NS=y
CONFIG_USER_NS=y
45 changes: 45 additions & 0 deletions tools/testing/selftests/pid_namespace/regression_enomem.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
#define _GNU_SOURCE
#include <assert.h>
#include <errno.h>
#include <fcntl.h>
#include <linux/types.h>
#include <sched.h>
#include <signal.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <syscall.h>
#include <sys/wait.h>

#include "../kselftest.h"
#include "../kselftest_harness.h"
#include "../pidfd/pidfd.h"

/*
* Regression test for:
* 35f71bc0a09a ("fork: report pid reservation failure properly")
* b26ebfe12f34 ("pid: Fix error return value in some cases")
*/
TEST(regression_enomem)
{
pid_t pid;

if (geteuid())
EXPECT_EQ(0, unshare(CLONE_NEWUSER));

EXPECT_EQ(0, unshare(CLONE_NEWPID));

pid = fork();
ASSERT_GE(pid, 0);

if (pid == 0)
exit(EXIT_SUCCESS);

EXPECT_EQ(0, wait_for_pid(pid));

pid = fork();
ASSERT_LT(pid, 0);
ASSERT_EQ(errno, ENOMEM);
}

TEST_HARNESS_MAIN
2 changes: 2 additions & 0 deletions tools/testing/selftests/pidfd/pidfd.h
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
#include <string.h>
#include <syscall.h>
#include <sys/mount.h>
#include <sys/types.h>
#include <sys/wait.h>

#include "../kselftest.h"

Expand Down

0 comments on commit 1e396a5

Please sign in to comment.