Skip to content

Commit

Permalink
scsi: libsas: Add missing annotation for sas_ata_qc_issue()
Browse files Browse the repository at this point in the history
Sparse reports a warning at sas_ata_qc_issue()

warning: context imbalance in sas_ata_qc_issue() - unexpected unlock
The root cause is the missing annotation at sas_ata_qc_issue()

Add the missing __must_hold(ap->lock) annotation

Link: https://lore.kernel.org/r/[email protected]
Reviewed-by: John Garry <[email protected]>
Signed-off-by: Jules Irenge <[email protected]>
Signed-off-by: Martin K. Petersen <[email protected]>
  • Loading branch information
irenge authored and martinkpetersen committed Apr 15, 2020
1 parent 4a0b746 commit 1e4ffb8
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/scsi/libsas/sas_ata.c
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,7 @@ static void sas_ata_task_done(struct sas_task *task)
}

static unsigned int sas_ata_qc_issue(struct ata_queued_cmd *qc)
__must_hold(ap->lock)
{
struct sas_task *task;
struct scatterlist *sg;
Expand Down

0 comments on commit 1e4ffb8

Please sign in to comment.