ALSA: hda - bug fix on return value when getting HDMI ELD info

In function snd_hdmi_get_eld(), the variable 'ret' should be initialized to 0. Otherwise it will be returned uninitialized as non-zero after ELD info is got successfully. Thus hdmi_present_sense() will always assume ELD info is invalid by mistake, and /proc file system cannot show the proper ELD info. Signed-off-by: Mengdong Lin <[email protected]> Cc: [email protected] Acked-by: David Henningsson <[email protected]> Signed-off-by: Takashi Iwai <[email protected]>
fracktal · Apr 2, 2013 · 2ef5692 · 2ef5692
1 parent ea019fd
commit 2ef5692
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/sound/pci/hda/hda_eld.c b/sound/pci/hda/hda_eld.c
@@ -320,7 +320,7 @@ int snd_hdmi_get_eld(struct hda_codec *codec, hda_nid_t nid,
 		     unsigned char *buf, int *eld_size)
 {
 	int i;
-	int ret;
+	int ret = 0;
 	int size;
 
 	/*