ksmbd: fix endless loop when encryption for response fails

If ->encrypt_resp return error, goto statement cause endless loop. It send an error response immediately after removing it. Fixes: 0626e66 ("cifsd: add server handler for central processing and tranport layers") Cc: [email protected] Signed-off-by: Namjae Jeon <[email protected]> Signed-off-by: Steve French <[email protected]>
fracktal · Oct 5, 2022 · 360c8ee · 360c8ee
1 parent d5919f2
commit 360c8ee
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/fs/ksmbd/server.c b/fs/ksmbd/server.c
@@ -235,10 +235,8 @@ static void __handle_ksmbd_work(struct ksmbd_work *work,
 	if (work->sess && work->sess->enc && work->encrypted &&
 	    conn->ops->encrypt_resp) {
 		rc = conn->ops->encrypt_resp(work);
-		if (rc < 0) {
+		if (rc < 0)
 			conn->ops->set_rsp_status(work, STATUS_DATA_ERROR);
-			goto send;
-		}
 	}
 
 	ksmbd_conn_write(work);