Skip to content

Commit

Permalink
ALSA: squash lines for simple wrapper functions
Browse files Browse the repository at this point in the history
Remove unneeded variables and assignments.

Signed-off-by: Masahiro Yamada <[email protected]>
Signed-off-by: Takashi Iwai <[email protected]>
  • Loading branch information
masahir0y authored and tiwai committed Sep 7, 2016
1 parent f3f6c61 commit 44cc4a0
Show file tree
Hide file tree
Showing 7 changed files with 13 additions and 43 deletions.
7 changes: 1 addition & 6 deletions sound/aoa/fabrics/layout.c
Original file line number Diff line number Diff line change
Expand Up @@ -1169,12 +1169,7 @@ static struct soundbus_driver aoa_soundbus_driver = {

static int __init aoa_fabric_layout_init(void)
{
int err;

err = soundbus_register_driver(&aoa_soundbus_driver);
if (err)
return err;
return 0;
return soundbus_register_driver(&aoa_soundbus_driver);
}

static void __exit aoa_fabric_layout_exit(void)
Expand Down
7 changes: 2 additions & 5 deletions sound/pci/asihpi/hpifunc.c
Original file line number Diff line number Diff line change
Expand Up @@ -2323,11 +2323,8 @@ u16 hpi_sample_clock_get_source_index(u32 h_control, u16 *pw_source_index)
u16 hpi_sample_clock_query_local_rate(const u32 h_clock, const u32 index,
u32 *prate)
{
u16 err;
err = hpi_control_query(h_clock, HPI_SAMPLECLOCK_LOCAL_SAMPLERATE,
index, 0, prate);

return err;
return hpi_control_query(h_clock, HPI_SAMPLECLOCK_LOCAL_SAMPLERATE,
index, 0, prate);
}

u16 hpi_sample_clock_set_local_rate(u32 h_control, u32 sample_rate)
Expand Down
6 changes: 1 addition & 5 deletions sound/pci/ctxfi/ctvmem.c
Original file line number Diff line number Diff line change
Expand Up @@ -166,11 +166,7 @@ static void ct_vm_unmap(struct ct_vm *vm, struct ct_vm_block *block)
static dma_addr_t
ct_get_ptp_phys(struct ct_vm *vm, int index)
{
dma_addr_t addr;

addr = (index >= CT_PTP_NUM) ? ~0UL : vm->ptp[index].addr;

return addr;
return (index >= CT_PTP_NUM) ? ~0UL : vm->ptp[index].addr;
}

int ct_vm_create(struct ct_vm **rvm, struct pci_dev *pci)
Expand Down
16 changes: 4 additions & 12 deletions sound/pci/emu10k1/p16v.c
Original file line number Diff line number Diff line change
Expand Up @@ -300,37 +300,29 @@ static int snd_p16v_pcm_open_capture(struct snd_pcm_substream *substream)
static int snd_p16v_pcm_hw_params_playback(struct snd_pcm_substream *substream,
struct snd_pcm_hw_params *hw_params)
{
int result;
result = snd_pcm_lib_malloc_pages(substream,
return snd_pcm_lib_malloc_pages(substream,
params_buffer_bytes(hw_params));
return result;
}

/* hw_params callback */
static int snd_p16v_pcm_hw_params_capture(struct snd_pcm_substream *substream,
struct snd_pcm_hw_params *hw_params)
{
int result;
result = snd_pcm_lib_malloc_pages(substream,
return snd_pcm_lib_malloc_pages(substream,
params_buffer_bytes(hw_params));
return result;
}


/* hw_free callback */
static int snd_p16v_pcm_hw_free_playback(struct snd_pcm_substream *substream)
{
int result;
result = snd_pcm_lib_free_pages(substream);
return result;
return snd_pcm_lib_free_pages(substream);
}

/* hw_free callback */
static int snd_p16v_pcm_hw_free_capture(struct snd_pcm_substream *substream)
{
int result;
result = snd_pcm_lib_free_pages(substream);
return result;
return snd_pcm_lib_free_pages(substream);
}


Expand Down
4 changes: 1 addition & 3 deletions sound/pci/ice1712/ice1724.c
Original file line number Diff line number Diff line change
Expand Up @@ -620,9 +620,7 @@ static const unsigned int stdclock_rate_list[16] = {

static unsigned int stdclock_get_rate(struct snd_ice1712 *ice)
{
unsigned int rate;
rate = stdclock_rate_list[inb(ICEMT1724(ice, RATE)) & 15];
return rate;
return stdclock_rate_list[inb(ICEMT1724(ice, RATE)) & 15];
}

static void stdclock_set_rate(struct snd_ice1712 *ice, unsigned int rate)
Expand Down
4 changes: 1 addition & 3 deletions sound/ppc/snd_ps3.c
Original file line number Diff line number Diff line change
Expand Up @@ -564,9 +564,7 @@ static int snd_ps3_pcm_hw_params(struct snd_pcm_substream *substream,

static int snd_ps3_pcm_hw_free(struct snd_pcm_substream *substream)
{
int ret;
ret = snd_pcm_lib_free_pages(substream);
return ret;
return snd_pcm_lib_free_pages(substream);
};

static int snd_ps3_delay_to_bytes(struct snd_pcm_substream *substream,
Expand Down
12 changes: 3 additions & 9 deletions sound/soc/intel/baytrail/sst-baytrail-ipc.c
Original file line number Diff line number Diff line change
Expand Up @@ -184,15 +184,9 @@ struct sst_byt {

static inline u64 sst_byt_header(int msg_id, int data, bool large, int str_id)
{
u64 header;

header = IPC_HEADER_MSG_ID(msg_id) |
IPC_HEADER_STR_ID(str_id) |
IPC_HEADER_LARGE(large) |
IPC_HEADER_DATA(data) |
SST_BYT_IPCX_BUSY;

return header;
return IPC_HEADER_MSG_ID(msg_id) | IPC_HEADER_STR_ID(str_id) |
IPC_HEADER_LARGE(large) | IPC_HEADER_DATA(data) |
SST_BYT_IPCX_BUSY;
}

static inline u16 sst_byt_header_msg_id(u64 header)
Expand Down

0 comments on commit 44cc4a0

Please sign in to comment.