Skip to content

Commit

Permalink
KVM: x86: fix TRACE_INCLUDE_PATH and remove -I. header search paths
Browse files Browse the repository at this point in the history
The header search path -I. in kernel Makefiles is very suspicious;
it allows the compiler to search for headers in the top of $(srctree),
where obviously no header file exists.

The reason of having -I. here is to make the incorrectly set
TRACE_INCLUDE_PATH working.

As the comment block in include/trace/define_trace.h says,
TRACE_INCLUDE_PATH should be a relative path to the define_trace.h

Fix the TRACE_INCLUDE_PATH, and remove the iffy include paths.

Signed-off-by: Masahiro Yamada <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
  • Loading branch information
masahir0y authored and bonzini committed Jan 25, 2019
1 parent 35b531a commit 5cd5548
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
4 changes: 0 additions & 4 deletions arch/x86/kvm/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,6 @@

ccflags-y += -Iarch/x86/kvm

CFLAGS_x86.o := -I.
CFLAGS_svm.o := -I.
CFLAGS_vmx.o := -I.

KVM := ../../../virt/kvm

kvm-y += $(KVM)/kvm_main.o $(KVM)/coalesced_mmio.o \
Expand Down
2 changes: 1 addition & 1 deletion arch/x86/kvm/trace.h
Original file line number Diff line number Diff line change
Expand Up @@ -1465,7 +1465,7 @@ TRACE_EVENT(kvm_hv_send_ipi_ex,
#endif /* _TRACE_KVM_H */

#undef TRACE_INCLUDE_PATH
#define TRACE_INCLUDE_PATH arch/x86/kvm
#define TRACE_INCLUDE_PATH ../../arch/x86/kvm
#undef TRACE_INCLUDE_FILE
#define TRACE_INCLUDE_FILE trace

Expand Down

0 comments on commit 5cd5548

Please sign in to comment.