Skip to content

Commit

Permalink
video: fbdev: sis: Drop useless call to SiS_GetResInfo()
Browse files Browse the repository at this point in the history
Coverity reported:

    Useless call (USELESS_CALL) side_effect_free: Calling
     SiS_GetResInfo(SiS_Pr, ModeNo, ModeIdIndex) is only useful for its
    return value, which is ignored.

And this is correct - so drop the call.

Signed-off-by: Sam Ravnborg <[email protected]>
Reported-by: Colin Ian King <[email protected]>
Addresses-Coverity: ("Useless call")
Acked-by: Thomas Zimmermann <[email protected]>
Cc: Colin Ian King <[email protected]>
Cc: Thomas Winischhofer <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
  • Loading branch information
sravnborg committed Dec 8, 2020
1 parent 4aca4db commit 604057e
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion drivers/video/fbdev/sis/init.c
Original file line number Diff line number Diff line change
Expand Up @@ -2659,7 +2659,6 @@ SiS_SetCRT1ModeRegs(struct SiS_Private *SiS_Pr, unsigned short ModeNo,
if(SiS_Pr->UseCustomMode) {
infoflag = SiS_Pr->CInfoFlag;
} else {
SiS_GetResInfo(SiS_Pr, ModeNo, ModeIdIndex);
if(ModeNo > 0x13) {
infoflag = SiS_Pr->SiS_RefIndex[RRTI].Ext_InfoFlag;
}
Expand Down

0 comments on commit 604057e

Please sign in to comment.